Update Error Docs#14934
Merged
ondrejmirtes merged 1 commit intoJul 7, 2026
Merged
Conversation
- Added `pureFunction.redundantUnlessCallable` and `pureMethod.redundantUnlessCallable` for functions/methods marked @pure-unless-callable-is-impure on a parameter that is already typed as a pure callable, where @phpstan-pure should be used instead. - Added `method.impureOverridePureUnlessCallable` for impure methods overriding a parent method marked @pure-unless-callable-is-impure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest
website/src/errorsIdentifiers.jsonupdate introduced three new error identifiers, all related to the@pure-unless-callable-is-impurePHPDoc tag. This PR documents them.New documentation pages
pureFunction.redundantUnlessCallable— a function is marked@pure-unless-callable-is-impurefor a parameter, but that parameter is already typed as apure-callable, so the tag has no effect and@phpstan-pureshould be used instead.pureMethod.redundantUnlessCallable— the same situation for a method.method.impureOverridePureUnlessCallable— an@phpstan-impuremethod overrides a parent method marked@pure-unless-callable-is-impure, breaking the inherited conditional-purity contract.Each page includes a minimal code example derived from the phpstan-src test fixtures (
FunctionPurityCheckandMethodSignatureRule), an explanation of the@pure-unless-callable-is-impuresemantics, and fixes covering both correcting the annotation and adjusting the parameter/purity contract.