Skip to content

fix(web): restore settled PR colors on hover - #10023

Open
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:t3code/color-settled-thread-hover
Open

fix(web): restore settled PR colors on hover#10023
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:t3code/color-settled-thread-hover

Conversation

@flamboh

@flamboh flamboh commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Note

🤖 GPT-6 Astra on behalf of Oliver

ELI5

Hovering a settled thread shows its PR number in the PR state's color again, including the selected thread.

Problem

The sidebar rename left the hover selectors targeting v2-row instead of sidebar-row, breaking the behavior introduced in #4451. Selected settled rows also skipped the hover classes.

Fix

Use the current row group and apply the hover classes to selected settled rows. Open, merged, closed, and draft colors remain consistent with other PR badges.

Validation: 41 focused tests passed, web typecheck passed, targeted lint completed with existing sidebar warnings. Verified the selected settled row in the local web client. Code review found no actionable issues.

UI Changes

Before

Screenshot supplied by Oliver.

Before: settled PR number stays gray on hover

After

Matching row captured in the isolated web client with the default dark theme.

After: settled open PR number turns green on hover

Changes made by GPT-6 Astra in Codex.

Note

Restore settled PR hover colors in SidebarThreadRow

  • Changes settledPrHoverColorClass in ThreadStatusIndicators.tsx to target the sidebar-row group-hover variant instead of v2-row.
  • Updates SidebarThreadRow in Sidebar.tsx so active slim rows include the transition and hover color classes instead of suppressing them.
  • Risk: Callers still using the v2-row group namespace will no longer receive the hover color classes.

Macroscope summarized 1f5ddeb.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 1f5ddeb

Macroscope's review found this PR approvable — This is a narrowly scoped UI bug fix that restores settled pull-request badge colors on sidebar-row hover by correcting selectors and applying the same behavior to active rows. Its runtime impact is limited to presentation, with updated tests and no broader product or infrastructure changes.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant