fix(web): restore settled PR colors on hover - #10023
Open
flamboh wants to merge 1 commit into
Open
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped UI bug fix that restores settled pull-request badge colors on sidebar-row hover by correcting selectors and applying the same behavior to active rows. Its runtime impact is limited to presentation, with updated tests and no broader product or infrastructure changes. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-6 Astra on behalf of Oliver
ELI5
Hovering a settled thread shows its PR number in the PR state's color again, including the selected thread.
Problem
The sidebar rename left the hover selectors targeting
v2-rowinstead ofsidebar-row, breaking the behavior introduced in #4451. Selected settled rows also skipped the hover classes.Fix
Use the current row group and apply the hover classes to selected settled rows. Open, merged, closed, and draft colors remain consistent with other PR badges.
Validation: 41 focused tests passed, web typecheck passed, targeted lint completed with existing sidebar warnings. Verified the selected settled row in the local web client. Code review found no actionable issues.
UI Changes
Before
Screenshot supplied by Oliver.
After
Matching row captured in the isolated web client with the default dark theme.
Changes made by GPT-6 Astra in Codex.
Note
Restore settled PR hover colors in
SidebarThreadRowsettledPrHoverColorClassin ThreadStatusIndicators.tsx to target thesidebar-rowgroup-hover variant instead ofv2-row.SidebarThreadRowin Sidebar.tsx so active slim rows include the transition and hover color classes instead of suppressing them.v2-rowgroup namespace will no longer receive the hover color classes.Macroscope summarized 1f5ddeb.