refactor(web): share bulk thread deletion between sidebars

[t3dotgg]

Both sidebar layouts keep their own bulk-delete loop. #4615 had to fix both copies so one failed deletion would not stop the remaining threads.

Use one shared loop for both layouts. It counts only successful deletions for shared-worktree checks, continues ordinary failures, and stops on interruption. Menus, confirmation dialogs, layout choice, and selection cleanup stay in their existing callers.

Verification

• 153 focused sidebar, selection, and worktree tests pass.
• Web typecheck and formatting pass.
• Targeted lint passes with warnings in unchanged code.
• Both disposable sidebar browser checks passed. No visual change is intended.

Browser verification

Both sidebar layouts passed Cancel and Confirm checks with disposable local threads. Cancel kept both selected threads. Confirm deleted only the two selected threads. Unselected threads and navigation remained available. A final confirmation check on the combined build kept the same dialog in both layouts.

Before uses main at 0c200c5. After uses the combined PR build at 8316ed24a9. Screenshots show confirmation only. The separate behavior checks exercised deletion.

Current sidebar

Legacy sidebar

Created with GPT-6 Astra in Codex.

Note

Share bulk thread deletion logic between LegacySidebar and Sidebar

• Adds deleteSelectedThreadEntries helper in Sidebar.logic.ts that processes entries sequentially, tracks successful keys, preserves the first failure, stops on interruption, and skips null results
• Refactors SidebarProjectItem in LegacySidebar.tsx and the bulk-delete flow in Sidebar.tsx to call the shared helper instead of inline deletion loops
• Adds tests in Sidebar.logic.test.ts covering ordering, failures, interruption, and skipped entries
• Behavioral Change: Sidebar now treats threads missing from threadByKeyRef as skipped (null) entries rather than failing; error toast still reports only the first failure

^{Macroscope summarized da8035f.}

[macroscopeapp]

Approvability

Verdict: Approved at 73a4d50

Macroscope's review found this PR approvable — This is a contained refactor that centralizes already-existing bulk thread deletion behavior for both sidebars, with focused tests covering its result handling. Existing deletion and worktree-cleanup semantics remain accounted for, with no defaults, schema, infrastructure, or static-analysis overrides changed.

No code changes detected at da8035f. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+10 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−2 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+12 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	8	8	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.6 KiB	−9 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+5 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.5 KiB	−14 B (−0.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	57.8 KiB	−44 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	9	−1 (−10.0%)	21	✅

Baseline: 7544d3d · PR result: da8035f · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.