fix(server): preserve due tasks when time formatting changes - #10438
Open
CouchRiv wants to merge 1 commit into
Open
fix(server): preserve due tasks when time formatting changes#10438CouchRiv wants to merge 1 commit into
CouchRiv wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — The production change narrowly fixes equality for equivalent fixed-time schedule formats, preventing an otherwise unnecessary save from postponing a pending run. It leaves actual schedule changes and interval behavior intact and includes focused regression coverage. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixed-time schedules now compare parsed hours and minutes, so saving
09:00instead of9:00preserves the pending occurrence.Why
Both formats are accepted by the schedule contract. The current string comparison treats them as a schedule change and recalculates the next run. If today's occurrence is already due but has not dispatched, that save can postpone it until tomorrow.
This targets the V2 branch in #2829. It reuses the existing time parser and leaves actual hour, minute, weekday and interval changes distinct.
Validation
09:30still reschedules.Checklist
Implemented and verified with GPT-6 in the Codex harness.