fix(server): load V2 replay fixtures on Windows - #10451
Open
CouchRiv wants to merge 1 commit into
Open
Conversation
Contributor
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — The change is limited to five replay test readers and uses the platform-aware path service to convert fixture URLs, fixing Windows path handling without affecting product runtime behavior. No defaults, schemas, production infrastructure, or static-analysis configuration are changed. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Use Effect's
Path.fromFileUrlin the five V2 replay fixture readers.Why
On Windows, decoding
URL.pathnameleaves a slash before the drive letter. An existing Claude approval replay fails withENOENTwhile trying to readC:\C:\..., before reaching the orchestrator.Converting the file URL through the platform path service lets the existing replay, contract and recovery tests load their transcripts. This targets the V2 branch in #2829.
Verified on Windows: the approval replay fails before the change and passes after it; the four other affected suites pass 17 tests, with one live-recording test skipped. Server typecheck and targeted lint/format checks pass.
Checklist
Implemented and verified with GPT-6 via Codex desktop.