Skip to content

fix(server): load V2 replay fixtures on Windows - #10451

Open
CouchRiv wants to merge 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
CouchRiv:fix/v2-replay-file-urls
Open

fix(server): load V2 replay fixtures on Windows#10451
CouchRiv wants to merge 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
CouchRiv:fix/v2-replay-file-urls

Conversation

@CouchRiv

@CouchRiv CouchRiv commented Sep 7, 2026

Copy link
Copy Markdown

What Changed

Use Effect's Path.fromFileUrl in the five V2 replay fixture readers.

Why

On Windows, decoding URL.pathname leaves a slash before the drive letter. An existing Claude approval replay fails with ENOENT while trying to read C:\C:\..., before reaching the orchestrator.

Converting the file URL through the platform path service lets the existing replay, contract and recovery tests load their transcripts. This targets the V2 branch in #2829.

Verified on Windows: the approval replay fails before the change and passes after it; the four other affected suites pass 17 tests, with one live-recording test skipped. Server typecheck and targeted lint/format checks pass.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Implemented and verified with GPT-6 via Codex desktop.

@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — The change is limited to five replay test readers and uses the platform-aware path service to convert fixture URLs, fixing Windows path handling without affecting product runtime behavior. No defaults, schemas, production infrastructure, or static-analysis configuration are changed.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant