Skip to content

feat(mcp): expose preview list and close - #10559

Merged
juliusmarminge merged 1 commit into
agents/mcp-thin/conversation-transferfrom
agents/mcp-thin/preview
Sep 7, 2026
Merged

feat(mcp): expose preview list and close#10559
juliusmarminge merged 1 commit into
agents/mcp-thin/conversation-transferfrom
agents/mcp-thin/preview

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 7, 2026

Copy link
Copy Markdown
Member

Part 9/16 of the shared-core and MCP stack. Based on #10558. Next: #10560.

Expose the existing PreviewManager list and explicit-tab close operations for the calling thread.

The existing preview capability and browser-access setting are required. Close uses the existing server/host lifecycle and does not claim renderer cleanup has finished. Broker race hardening is separate.

MCP-only rebuild of #8724, preserving attribution to Julius Marminge's original work. Original branches remain available for separate service follow-ups.

Validation: The composed stack passes 94 tests across 12 focused files, including shared core MCP and real MCP/V2 integration, attachment intake, project RPC/service contracts, and client model command selection. Server/contracts/shared/client-runtime typechecks and targeted format/lint/diff checks pass. New behavior coverage lives with the shared operation; no per-tool mock suite was added. Current-head CI is shown below.

Layer size: 7 files, +102/-1. No domain-service production implementation or documentation files change in this MCP layer.

Prepared with Codex in the OpenAI agent runtime.

@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 7, 2026
@juliusmarminge juliusmarminge changed the title feat(mcp): expose preview tab list and close feat(mcp): expose preview list and close Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds two production MCP capabilities for preview-tab discovery and closure, including a destructive close operation and a broader read-only Claude tool surface. The implementation is scoped and gated by existing preview permissions, but the new runtime behavior is not directly covered by tests, so human review is warranted.

No code changes detected at bcb7b21. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for bcb7b21.

This comment will update automatically after the next completed run.

Comment thread apps/server/src/mcp/toolkits/previewControls/handlers.ts
@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/preview branch from b74fb6c to 0893174 Compare September 7, 2026 19:44
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/preview branch from f6be1a1 to 73297df Compare September 7, 2026 20:48
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/preview branch from 73297df to bcb7b21 Compare September 7, 2026 20:55
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge merged commit 9b51250 into t3code/codex-turn-mapping Sep 7, 2026
40 of 45 checks passed
@juliusmarminge
juliusmarminge deleted the agents/mcp-thin/preview branch September 7, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant