Skip to content

feat(mcp): expose the existing thread search query - #10561

Merged
juliusmarminge merged 1 commit into
agents/mcp-thin/preferencesfrom
agents/mcp-thin/thread-search
Sep 7, 2026
Merged

feat(mcp): expose the existing thread search query#10561
juliusmarminge merged 1 commit into
agents/mcp-thin/preferencesfrom
agents/mcp-thin/thread-search

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 7, 2026

Copy link
Copy Markdown
Member

Part 11/16 of the shared-core and MCP stack. Based on #10560. Next: #10562.

Expose the existing bounded searchThreads query and return only matches from the calling project.

This filters the global top results, so a project can underfill the requested limit. It is not exhaustive or paginated. Project-first SQL pagination and search-service correctness changes belong in a separate service PR.

MCP-only rebuild of #8721, #8722, preserving attribution to Julius Marminge's original work. Original branches remain available for separate service follow-ups.

Validation: The composed stack passes 94 tests across 12 focused files, including shared core MCP and real MCP/V2 integration, attachment intake, project RPC/service contracts, and client model command selection. Server/contracts/shared/client-runtime typechecks and targeted format/lint/diff checks pass. New behavior coverage lives with the shared operation; no per-tool mock suite was added. Current-head CI is shown below.

Layer size: 4 files, +32/-1. No domain-service production implementation or documentation files change in this MCP layer.

Prepared with Codex in the OpenAI agent runtime.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 7, 2026
@juliusmarminge juliusmarminge changed the title feat(mcp): expose existing thread search feat(mcp): expose the existing thread search query Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 6342c1c.

This comment will update automatically after the next completed run.

@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a production MCP capability that exposes thread-content search and broadens the default read-only Claude tool allowlist. The query is bounded and project-scoped, but the default capability change warrants human review.

No code changes detected at 6342c1c. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/thread-search branch from eb9fd87 to 2e1bfbf Compare September 7, 2026 19:44
Comment thread apps/server/src/mcp/toolkits/thread/handlers.ts
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@juliusmarminge
juliusmarminge force-pushed the agents/mcp-thin/thread-search branch from 0024529 to 6342c1c Compare September 7, 2026 20:55
@juliusmarminge
juliusmarminge merged commit 3151e72 into t3code/codex-turn-mapping Sep 7, 2026
25 checks passed
@juliusmarminge
juliusmarminge deleted the agents/mcp-thin/thread-search branch September 7, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant