Skip to content

test(server): match V2 tool output redaction in retention coverage - #10865

Closed
saphid wants to merge 383 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-redaction-retention-test-20260909
Closed

saphid wants to merge 383 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-redaction-retention-test-20260909

Conversation

@saphid

@saphid saphid commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The V2 tool-output redaction change leaves the foundation retention test expecting the old { truncated: true } output preview. Test Server 1 fails on current V2 integrations for #10024 and #10025 because replay and live payloads now intentionally omit that output.

Update the assertion to require omission. The test still checks the transport size limit and verifies that both the stored event and full detail projection retain the original 9 MB output. Production behavior is unchanged.

Validation on V2 base 7dd9873ed: 56 focused foundation/wire-projection tests pass, server typecheck passes, and targeted lint/format/diff checks pass. The stale assertion is reproduced in both linked PRs' Test Server 1 failures. Independent Claude Opus 5 high review was unavailable during this audit: the direct launcher exited 1 with expired OAuth before inference.

Prepared with GPT-6 in the Codex/T3 harness.

juliusmarminge and others added 30 commits September 7, 2026 23:12
Keep positive sub-minute schedules readable without accepting corrupt zero or negative persisted intervals.

Co-authored-by: codex <codex@users.noreply.github.com>
Cancel pending prompt completions without restarting ACP, and keep text-only monitor acknowledgements tracked as background work.

Co-authored-by: codex <codex@users.noreply.github.com>
Allow merge-back from provider-finished runs awaiting checkpoint capture while keeping waiting runs visible but non-interruptible in mobile.

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge and others added 3 commits September 8, 2026 17:04
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 9, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2088c00

Macroscope's review found this PR approvable — This is a self-contained, one-line test expectation update in a test-only file. It aligns replay/live transport assertions with existing output redaction while continuing to verify that full output remains retained in persistence and projections.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from ed5dc41 to 2b1139a Compare September 10, 2026 19:28
@juliusmarminge

Copy link
Copy Markdown
Member

Closing as already covered on v2 by commit 8207e55. FoundationPersistence.test.ts now asserts that the transported dynamic-tool payload omits output, while retaining the full persisted-output checks. The exact one-line patch reverse-applies to the current branch, and the replacement commit is already on the remote v2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants