Skip to content

docs: propose consistency for file actions - #12683

Open
saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:docs/consistency-file-actions
Open

saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:docs/consistency-file-actions

Conversation

@saphid

@saphid saphid commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

What Changed

Proposes the consistency rule for file actions, with scope, platform boundaries and observable acceptance cases.

Why

The same object or operation should keep its meaning across presentations. This records the cross-surface constraint separately from the implementation so it can be reviewed on its own. It is a proposal, not a claim of prior ratification or complete compliance.

Tracking: https://github.com/saphid/personal-ops/issues/142

Implementation: #12869 (it carries this documentation commit until this PR merges).

Validation: documentation-only diff, checked against the current implementation and recovered research.

Model: GPT-6 Astra via Codex/T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 20, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at e270812

Macroscope's review found this PR approvable — The PR adds a single internal Markdown proposal and does not modify executable code, configuration, product defaults, or static-analysis behavior. Its impact is limited to documenting design scope and verification expectations.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1d31fb98-4056-4baf-ba91-dd0a19433635

📥 Commits

Reviewing files that changed from the base of the PR and between 7445aa7 and e270812.

📒 Files selected for processing (1)
  • docs/internals/consistency-file-actions.md

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds a proposal for consistent workspace-relative file actions across context menus, keyboard commands, touch menus, and composer mentions. It defines ownership, exclusions, state preservation, platform boundaries, and verification requirements.

Changes

Workspace File Actions

Layer / File(s) Summary
File action behavior contract
docs/internals/consistency-file-actions.md
Defines workspace and environment ownership, supported Web and Electron menus, excluded references, composer state preservation, platform boundaries, and verification cases.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the documentation change: a proposal for consistent file actions.
Description check ✅ Passed The description explains what changed and why, identifies the proposal scope, and states that the change is documentation-only. The UI section is not required because no UI was changed. The checklist …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant