fix(web): the pull request badge reads at the meta size again - #13175
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped UI bug fix that reuses existing button primitives to restore the pull-request badge’s meta-sized presentation without changing data, navigation intent, or broader workflows. The lint-threshold update only tightens CI enforcement, and the open feedback is limited to a non-blocking primitive-consistency concern. You can add or adjust custom eligibility rules. Learn more. |
| {...linkProps} | ||
| /> | ||
| isStack ? ( | ||
| <button type="button" {...triggerProps} /> |
There was a problem hiding this comment.
Shared primitives over custom controls: this styled raw <button> rebuilds the existing Button control. Please render it through Button from components/ui/button instead.
Suggested fix: restore the Button primitive and its import; this requires changes outside this hunk, so no inline diff is provided.
Posted via Macroscope — UI Consistency
|
UI consistency review completed with one inline finding. Posted via Macroscope — UI Consistency |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthrough
ChangesThread status controls
Restyle ceiling
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The trigger-rendering and styling update appears ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
bfa1118 to
7c6fc07
Compare
Dismissing prior approval to re-evaluate 7c6fc07
#13034 rendered the thread pull request badge through InlineButton in the sidebar and Button size="xs" in the composer. Both brought their own type (font-medium, and 14px from the row or from Button below sm), and the ghost Button muted the glyph, so the badge grew and lost its state color. The badge now takes a render prop for the control it sits in and owns only its content: the glyph and number at text-xs, regular weight, tabular figures, in the state tone. The sidebar row renders it in an InlineButton, the composer in ComposerControl size="xs" like its neighbours, and the badge fills in the link or stack-button element. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
7c6fc07 to
d6287ee
Compare
Dismissing prior approval to re-evaluate d6287ee
This comment has been minimized.
This comment has been minimized.
## What's Changed * chore(mobile): drop dead nitro-markdown tgz override and @expo/metro-runtime by @juliusmarminge in pingdotgg/t3code#13148 * feat(web): show settings scope as a sentence at the top of the page by @juliusmarminge in pingdotgg/t3code#13139 * refactor(web): move settings scope pickers into breadcrumbs by @Yash-Singh1 in pingdotgg/t3code#13165 * feat(auth): share provider sign-in flows and credential bindings by @juliusmarminge in pingdotgg/t3code#12983 * refactor(mobile): git sheets use uniwind platform variants instead of className ternaries by @juliusmarminge in pingdotgg/t3code#13161 * chore(mobile): name the two project favicon caches by their job by @juliusmarminge in pingdotgg/t3code#13160 * revert(mobile): git sheets back to Platform.OS ternaries (un-guarded uniwind variants broke both platforms) by @juliusmarminge in pingdotgg/t3code#13169 * docs(mobile): document the two mobile routes that intentionally skip deep links by @juliusmarminge in pingdotgg/t3code#13164 * refactor(mobile): break module cycles with focused extractions by @juliusmarminge in pingdotgg/t3code#13151 * fix(server): generate PR diffs from branch changes by @Yash-Singh1 in pingdotgg/t3code#13170 * fix(web): preserve nested scroll behavior in chat timeline by @Yash-Singh1 in pingdotgg/t3code#13167 * test(web): cover usage model ordering without static markup by @flamboh in pingdotgg/t3code#13104 * fix(desktop): find linuxbrew node for the WSL backend by @CodyRay in pingdotgg/t3code#7827 * chore(models): use GPT-6 Luna for text generation by @extoci in pingdotgg/t3code#13115 * fix(mobile): keep ordinary offline outbox failures out of console.warn by @juliusmarminge in pingdotgg/t3code#13144 * feat(providers): check remote compatibility ranges by @juliusmarminge in pingdotgg/t3code#13130 * chore(lint): keep mobile theme escape-hatch allowlist honest by @juliusmarminge in pingdotgg/t3code#13146 * fix(web): the pull request badge reads at the meta size again by @juliusmarminge in pingdotgg/t3code#13175 * fix(mobile): uniwind platform variants stay guarded on both platforms by @juliusmarminge in pingdotgg/t3code#13172 * refactor(mobile): git sheets use uniwind platform variants instead of className ternaries by @juliusmarminge in pingdotgg/t3code#13185 * refactor(mobile): remaining className platform ternaries become class variants by @juliusmarminge in pingdotgg/t3code#13188 * fix(web): align provider emails without clipping by @Derpedyea in pingdotgg/t3code#13174 * perf(mobile): recycle the default v2 home list and scope the snooze minute tick by @juliusmarminge in pingdotgg/t3code#13149 * refactor(mobile): retire the legacy grouped thread list by @juliusmarminge in pingdotgg/t3code#13183 * fix(server): background PR checks spend less GitHub quota by @juliusmarminge in pingdotgg/t3code#13189 * fix(server): background PR sync reads summaries in batches by @juliusmarminge in pingdotgg/t3code#13198 * fix(server): GitHub PR lookups stop probing owner-qualified heads by @juliusmarminge in pingdotgg/t3code#13200 * chore(mobile): clear the legacy-list deletion fallout by @juliusmarminge in pingdotgg/t3code#13203 ## New Contributors * @CodyRay made their first contribution in pingdotgg/t3code#7827 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260922.2123...v0.0.43-nightly.20260923.2135 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260923.2135
#13034 rendered the thread pull request badge through
InlineButtonin the sidebar andButton size="xs"in the composer. Both brought their own type:font-medium, plus 14px from the one-line sidebar row or from Button belowsm. The ghost Button also muted the glyph, so the badge grew and lost its state color.The badge now takes a
renderprop for the control it sits in, and owns only its content: the glyph and number attext-xs, regular weight, tabular figures, in the state tone. Base UI'suseRendermerges the badge's element (the link, or the stack button) and its click behavior into that control, the same way everycomponents/uiexport composesrender.render={<InlineButton />}render={<ComposerControl size="xs" />}, the same control as the model and branch pickers next to itThis also drops one
no-restylefinding (the tone className on Button), so the ceiling goes 628 → 627.Measured in a real client: 12px/400 in the state color in both places. The composer control is 24px tall on desktop and 28px on narrow, matching its neighbours.
Composer on desktop, after:
Claude Opus 5.5 via Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit