Skip to content

fix(web): use the styled tooltip for the sidebar project settings button - #7430

Closed
kevin-tritz wants to merge 1 commit into
pingdotgg:mainfrom
kevin-tritz:fix/project-settings-tooltip
Closed

fix(web): use the styled tooltip for the sidebar project settings button#7430
kevin-tritz wants to merge 1 commit into
pingdotgg:mainfrom
kevin-tritz:fix/project-settings-tooltip

Conversation

@kevin-tritz

@kevin-tritz kevin-tritz commented Aug 18, 2026

Copy link
Copy Markdown

#7209 migrated native title tooltips to the styled Tooltip and added the t3code/no-native-title-tooltip lint rule, but the rule can't see title passed through component props, so the project settings button in the sidebar's project picker kept the browser-native tooltip and clashes with the styled tooltips around it.

Now the button renders through Tooltip/TooltipTrigger/TooltipPopup like the rest of the app; the aria-label stays for screen readers. No behavior change beyond tooltip presentation.

Screenshot

Styled tooltip on the project settings button

(The before state is the OS-native tooltip, which doesn't render in-page and so can't be captured in a screenshot.)

Verification

  • Web typecheck, 0 errors
  • Repo lint, 0 errors
  • Browser-verified in an isolated paired environment

Implemented by Claude Fable 5 through the Claude Code harness in T3 Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only tooltip presentation in the sidebar; no auth, data, or navigation logic changes.

Overview
Replaces the browser-native title tooltip on the project settings gear in the sidebar project picker with the app’s Tooltip / TooltipTrigger / TooltipPopup pattern, so it matches nearby controls after the styled-tooltip migration.

The title prop is removed from the settings Button; aria-label is unchanged for screen readers. Click behavior (handleProjectSettings, stopPropagation on pointer down) is the same—only hover hint presentation changes.

Reviewed by Cursor Bugbot for commit ec99f82. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace browser title tooltip with styled tooltip on sidebar project settings button

Wraps the project settings button in Sidebar.tsx with a Tooltip component, replacing the native browser title attribute with a TooltipPopup displaying "Project settings for ${project.displayName}". The aria-label is retained; only the tooltip presentation changes.

Macroscope summarized ec99f82.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e420606-20ae-4817-9742-590f6f7a6362

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 18, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ec99f82

Macroscope's review found this PR approvable — This change replaces a native HTML title tooltip with a styled Tooltip component for visual consistency. It's a cosmetic-only change with no impact on button functionality or runtime behavior.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg

t3dotgg commented Aug 27, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

Closing this tooltip-only PR in the backlog cleanup. The button keeps the same action and accessible label. The shared Tooltip replacement follows the current convention and can be folded into the next sidebar change without retaining a separate branch.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. If GitHub does not let you reopen it, leave a comment here and we'll take another look.

@t3dotgg t3dotgg closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants