feat(swift-ios): add reliable text and code sizing - #7612
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces persisted text and code-size controls with app-wide Dynamic Type behavior and propagation through multiple SwiftUI and UIKit rendering paths. The new settings UI, global trait handling, and serialized save changes make the production impact broad enough to warrant human review. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
e136164 to
f3634dc
Compare
f3634dc to
019c8b2
Compare
|
Ready for human review on rebuilt current-target head |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 019c8b2. Configure here.
019c8b2 to
0eede8d
Compare
0eede8d to
dd3fc8b
Compare
7597e3c
into
pingdotgg:t3code/rebuild-mobile-app-swift

The native app had no independent text and code size controls. This adds both controls with live previews in Settings, relative to iOS Dynamic Type.
Size changes apply immediately. Ordered settings writes and rollback to the last successful save prevent older failures or reconnects from restoring stale choices. The update preserves the current environment-owned automatic settlement settings.
Validation: 94 focused native tests passed at
dd3fc8b3f42a44f767d7d85c37599c94800c421d, rebased onto SwiftUI base614a7b672a86ee638f284298fe26e8b0194e0eaa. Coverage includes sizing, settings write order and rollback, legacy settings, and reconnect persistence. Live slider Save and relaunch checks on this updated branch remain incomplete.Historical images and videos
These captures belong to original head
019c8b219d6fac4845f76ac06348bdc57446b7f3. They were not recaptured or revalidated for the modernized branch.Light mode before:
Light mode after:
Dark mode before:
Dark mode after:
Before video · Interaction video
Tracking: native work item.
Modernized and fixed with GPT-6 in Codex.