fix(web): stop phrasing unknown provider auth as a verification failure - #7934
fix(web): stop phrasing unknown provider auth as a verification failure#7934Swayam2004 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Skipped Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically. |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. Closing this duplicate wording change in favor of #7943. Both distinguish a ready provider with unreported authentication from an actual authentication failure. Keep the regression test in the retained PR. The Grok reliability merge does not by itself remove the fallback for every provider, so the status-copy fix still needs review. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. If GitHub does not let you reopen it, leave a comment here and we'll take another look. |
Providers whose health check fully succeeds but never reports an auth result render this detail on every cycle: "Installed and ready, but authentication could not be verified." Nothing failed. The status is unknown, and the copy reads as an auth failure. Grok hits this every five minutes (#7932).
Reworded the final fallback in
getProviderSummary. Server-supplied messages still take precedence, and all other branches are untouched.Before:
Installed and ready, but authentication could not be verified.After:
Installed and ready. Authentication status was not reported.Adds a focused test covering the fallback branch. Happy to attach real before/after captures if wanted.
Work done by ox-alpha (opencode harness).
Note
Low Risk
UI copy-only change in provider status text plus unit tests; no auth or backend behavior changes.
Overview
Ready providers with unknown auth no longer look like they failed verification. The fallback detail in
getProviderSummarynow says authentication was not reported instead of implying a check failed.Server-supplied messages still win. Adds tests for the fallback, message override, and authenticated headline.
Reviewed by Cursor Bugbot for commit 03d7fe1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Reword unknown provider auth detail in
getProviderSummaryto not imply verification failureChanges the fallback detail string for available-but-unverified providers from 'Installed and ready, but authentication could not be verified.' to 'Installed and ready. Authentication status was not reported.' Adds tests in providerStatus.test.ts covering the fallback case, server-supplied message override, and authenticated provider headline.
Macroscope summarized 03d7fe1.