Skip to content

feat(swift-ios): copy thread metadata from row menus - #8622

Merged
t3dotgg merged 7 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:swiftui/pr-140-thread-copy-actions
Sep 6, 2026
Merged

feat(swift-ios): copy thread metadata from row menus#8622
t3dotgg merged 7 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:swiftui/pr-140-thread-copy-actions

Conversation

@saphid

@saphid saphid commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

SwiftUI thread rows now expose a Copy submenu for Path, Branch when present, and Thread ID. Actions derive their values from one copy context built from the row's current presentation context.

The refresh integrates the submenu with the native parent's current row and context-menu structure.

Verification — 5 September 2026

Head: 5d68355bb30073db809a8d0b6d196360d72a0efe. Refreshed against t3code/rebuild-mobile-app-swift at b99405468a6b2be1e0f67d551ece824b1627e35c.

ThreadCopyActionsTests: 11 passed, 0 failed; the app and test target compiled. Current-build menu and clipboard visual evidence has not been refreshed.

This PR targets the native development branch. Merging it there does not deliver it to main.

Earlier visual evidence

These retained captures show earlier revisions. They have not been recaptured or revalidated against the head above.

Before — no Copy action

After — Copy action collapsed

Copy submenu opened

Before to after comparison

Copy menu interaction

Clean poster

Annotated poster

Clean MP4

Annotated MP4

Play the cropped menu interaction video

Before — full window

After — full window

Before — no Copy action

After — Copy action collapsed

Copy submenu opened

Before to after comparison

Copy menu interaction

Before — full window

After — full window

Tracking issue: https://github.com/saphid/t3code-personal/issues/140.

Repair and review: GPT-6 in Codex, with GPT-5.6 Sol workers. A direct Claude Opus 5 review launch was attempted with high effort but exited 1 because OAuth had expired; no Claude review occurred.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ef903f05-804e-4bd3-af8b-4392e9cc1eb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 29, 2026
Comment thread apps/swift-ios/Features/Workspace/ThreadCopyActions.swift

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 05a8d68. Configure here.

Comment thread apps/swift-ios/Features/Workspace/WorkspaceView.swift
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new production thread-row copy workflow, including clipboard writes for workspace paths and thread/environment identifiers, rather than only changing internal structure. It also adjusts environment resolution on an existing path, so the runtime and metadata-handling changes extend beyond test-only coverage.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/swift-ios/Features/Workspace/WorkspaceView.swift
@github-actions github-actions Bot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 29, 2026
@saphid

saphid commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Maintainers, this is ready for human review and classified direct against live SwiftUI target c49bcc5d8a56324eb0ad9cf1b19d5dcc6ca0caa0. None of the five changed paths overlaps Theo's new commit, and the merge-tree simulation is clean. Head 2cc5a7e28 has green required CI, 10/10 focused native tests, a successful full app/test-target Simulator build, no unresolved review threads, and successful CodeRabbit, Cursor, and Macroscope correctness reviews. The PR body now pins every image to immutable media commit 08c021141 and includes a validated clean/annotated 10.07-second proof pair.

…r-8622-b994

# Conflicts:
#	apps/swift-ios/Features/Workspace/HomeThreadCollectionView.swift
@saphid saphid changed the title SwiftUI thread rows: copy thread metadata feat(swift-ios): copy thread metadata from row menus Sep 5, 2026
@t3dotgg
t3dotgg merged commit 58af3e6 into pingdotgg:t3code/rebuild-mobile-app-swift Sep 6, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants