fix(swift-ios): refresh passive threads sooner - #8644
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09745e6. Configure here.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The production Swift iOS default refresh cadence changes from 20 seconds to 5 seconds, alongside adaptive polling and failure backoff that alter passive thread freshness and background HTTP traffic. These customer-visible runtime and default changes warrant human review despite the added deterministic tests. You can add or adjust custom eligibility rules. Learn more. |
e0b2419 to
8d17864
Compare
84f0294
into
pingdotgg:t3code/rebuild-mobile-app-swift

Home previously refreshed non-selected SwiftUI environments every 20 seconds. This change polls them every 5 seconds while work is active or changes arrive, and every 10 seconds while idle. Failed environments retry after 20 seconds without slowing healthy peers.
Rebased onto
t3code/rebuild-mobile-app-swiftat614a7b672a. The current thread sync handling and multi-environment test fixtures are preserved.Validation: 27 focused native tests passed on
8d17864a88ac56732dc17278a3c82946b8b06391, covering passive refresh and multi-environment behavior. Range review andgit diff --checkpassed.Earlier evidence
Original Dev 55 phone report. This report belongs to the earlier revision and was not recaptured for this rebase.
Tracking: native work item 237.
Modernized and fixed with GPT-6 in Codex.