Skip to content

fix(swift-ios): refresh passive threads sooner - #8644

Merged
t3dotgg merged 2 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:fix/swiftui-passive-thread-refresh-upstream
Sep 6, 2026
Merged

fix(swift-ios): refresh passive threads sooner#8644
t3dotgg merged 2 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:fix/swiftui-passive-thread-refresh-upstream

Conversation

@saphid

@saphid saphid commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Home previously refreshed non-selected SwiftUI environments every 20 seconds. This change polls them every 5 seconds while work is active or changes arrive, and every 10 seconds while idle. Failed environments retry after 20 seconds without slowing healthy peers.

Rebased onto t3code/rebuild-mobile-app-swift at 614a7b672a. The current thread sync handling and multi-environment test fixtures are preserved.

Validation: 27 focused native tests passed on 8d17864a88ac56732dc17278a3c82946b8b06391, covering passive refresh and multi-environment behavior. Range review and git diff --check passed.

Earlier evidence

Original Dev 55 phone report. This report belongs to the earlier revision and was not recaptured for this rebase.

Tracking: native work item 237.

Modernized and fixed with GPT-6 in Codex.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b32274ec-7995-4bf1-8c15-001d12caf19a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 29, 2026
Comment thread apps/swift-ios/App/NativeFeatureClient.swift Outdated
@saphid
saphid marked this pull request as ready for review August 29, 2026 13:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 09745e6. Configure here.

Comment thread apps/swift-ios/App/NativeFeatureClient.swift
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The production Swift iOS default refresh cadence changes from 20 seconds to 5 seconds, alongside adaptive polling and failure backoff that alter passive thread freshness and background HTTP traffic. These customer-visible runtime and default changes warrant human review despite the added deterministic tests.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg force-pushed the fix/swiftui-passive-thread-refresh-upstream branch from e0b2419 to 8d17864 Compare September 6, 2026 22:10
@t3dotgg
t3dotgg merged commit 84f0294 into pingdotgg:t3code/rebuild-mobile-app-swift Sep 6, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants