feat(mcp): expose current environment diagnostics - #8726
juliusmarminge wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
There was a problem hiding this comment.
Reviewed the new EnvironmentMcpService, its toolkit wiring, and the environmentMcp contract against the Effect service conventions. Module layout (namespace imports of Effect subpaths, inline Context.Service interface, make then layer, dependencies acquired via yield*) looks right; two findings on the error model.
Posted via Macroscope — Effect Service Conventions
Thread transfer impact
This comment will update automatically after the next completed run. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces and registers a new authenticated MCP capability that exposes environment, provider health, authentication summaries, and server-owned preferences to provider sessions. Its read-only and allowlisted design limits risk, but the new production data boundary and session-tool availability require human review. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
0a9b7e7 to
26f239a
Compare
There was a problem hiding this comment.
One retained finding: EnvironmentMcpFailure still drops the underlying failure when the service wraps a real error. See the inline comment.
Posted via Macroscope — Effect Service Conventions
c24bb8c to
0775269
Compare
0775269 to
000d343
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit 000d343. Configure here.
0982610 to
512391d
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Superseded as the active MCP proposal by #10560 in the rebuilt MCP stack, following the maintainer request to review thin service wrappers separately from service hardening. This is not a full feature-parity replacement. Updates require a live full-access/default caller under the existing ThreadCommandExecutor. Provider configuration, secrets and admin controls are not exposed. No new settings store or lock service. Closing this mixed proposal without merging. The remote branch |

Problem
Agents could not inspect the identity or safe operational state of the T3 environment backing their current conversation without relying on unrelated settings payloads.
Change
Add
t3_environment_read, backed by the existing environment, provider registry, and settings services. It returns a paged provider-health summary, explicit safe capabilities, and a narrow server-owned preference projection.Behavior
The tool is current-environment only, read-only, and closed-world. It reads cached provider state without refreshing, installing, or authenticating providers. Human-readable diagnostics are Unicode-safe and bounded; credentials, provider configuration, model inventories, paths, raw diagnostics, and administrative fields never enter the result. Environment mismatch is checked before provider/settings reads, and finite public failure codes do not expose internal causes.
Focused validation
tools/listroot-object and annotation coveragegit diff --checkDependency
Bottom layer of native stack 8782, based on
t3code/codex-turn-mappingat the pinned rollout target. #8728 adds the dependent preference mutation.Implemented by GPT-5.6-Sol via Codex in T3 Code.