feat(mcp): run scheduled tasks immediately - #8731
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
There was a problem hiding this comment.
Reviewed the changed Effect service code (ScheduledTaskService, Orchestrator, ThreadLaunchService, ThreadManagementService, MCP toolkit/handlers, contracts) against the service conventions. Two convention violations found, both in apps/server/src/scheduledTasks/. The new policyCeiling plumbing, getCommandReceipt exposure, and makeKeyedSerialExecutor usage all follow existing module/layer conventions.
Posted via Macroscope — Effect Service Conventions
Thread transfer impact
This comment will update automatically after the next completed run. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces a new MCP workflow that can durably create threads, dispatch agent runs, update scheduler state, and replay commands across multiple orchestration layers. It also changes shared policy enforcement and dispatch locking, making the runtime and authorization impact broad enough to require human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
One convention finding on the new scheduled-task manual-run errors; everything else (namespace imports, layer/service shape, dependency acquisition, test seams) looks consistent with the repo conventions.
Posted via Macroscope — Effect Service Conventions
8ba30b8 to
c0b2fe8
Compare
There was a problem hiding this comment.
One convention finding in the Effect service changes: new code in Orchestrator.ts references the standalone CommandReceiptStoreV2Shape type instead of the inferred Foo["Service"] interface. Everything else (tagged manual-run errors with derived messages, namespace imports, keyed serial executor as a pure helper, test-only service seams) looks consistent with the conventions.
Posted via Macroscope — Effect Service Conventions
c01ff20 to
9d2539a
Compare
fa0bdb6 to
e8823bd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit e8823bd. Configure here.
b82facd to
2ac9bfe
Compare
c3f04e2 to
12fc18b
Compare
b07e89c to
c5a6c97
Compare
|
Superseded as the active MCP proposal by #10562 in the rebuilt MCP stack, following the maintainer request to review thin service wrappers separately from service hardening. This is not a full feature-parity replacement. Requires a full-access/default caller. Each call is a new manual run, not an idempotent retry. Returned bookkeeping is not provider turn completion; durable keyed retries and scheduler hardening are separate. Closing this mixed proposal without merging. The remote branch |

Problem
Scheduled tasks can be managed through MCP, but agents could not trigger one immediately without bypassing scheduler bookkeeping or risking duplicate work on retry.
Change
run_scheduled_task_nowwith a required stable request key.ScheduledTaskService,ThreadLaunchService, and V2 command receipts.Behavior
Fresh calls re-read the task and bound target under admission, enforce current project and runtime/interaction ceilings, and return durable thread, message, run, and receipt identities. Accepted retries return the original effect after task changes or deletion. Conflicting key reuse fails without mutating the losing task. A successful partial-launch resume does not rewrite
runCount,nextRunAt, or the latest run summary.Validation
@t3tools/contractsandt3typechecks.Base
Standalone PR on
t3code/codex-turn-mappingat415ed0f73b97f1655b6282492f81d0b2bba3a9cc.Implemented by GPT-5.6-Sol via Codex in T3 Code.