feat(web): simplify sidebar drag destination cues - #9750
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained sidebar UX refinement that changes only drag-time destination cues and temporarily hides existing row controls; the underlying drag targets, drop actions, and persistence remain unchanged. Documentation is updated alongside the isolated UI change, with no schema, infrastructure, security, billing, or static-analysis impact. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 896abc2
896abc2 to
84346fb
Compare
Web previewhttps://t3code-5ybw14xa7-pinglabs.vercel.app (for 85bf36e) Open this exact URL — the hosted-app origin is baked in at build time. |
84346fb to
cd1bd0b
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
cd1bd0b to
0186450
Compare
0186450 to
85bf36e
Compare
## What's Changed * fix(web): show Tux icon for WSL environments by @UtkarshUsername in pingdotgg/t3code#8511 * perf(web): speed up folder menu sorting by @AksharP5 in pingdotgg/t3code#10190 * style(web): fix inconsistencies in new settings layouts by @extoci in pingdotgg/t3code#10177 * feat(threads): persist manual active thread order by @juliusmarminge in pingdotgg/t3code#9729 * feat(mobile): arrange active threads from both thread lists by @juliusmarminge in pingdotgg/t3code#9730 * feat(web): drag threads across sections with consistent motion by @juliusmarminge in pingdotgg/t3code#9731 * feat(web): simplify sidebar drag destination cues by @juliusmarminge in pingdotgg/t3code#9750 * fix(mobile): keep pending tasks queued when a send fails in flight by @juliusmarminge in pingdotgg/t3code#10245 * feat(mobile): show new-task drafts alongside pending tasks in the thread list by @juliusmarminge in pingdotgg/t3code#10260 * feat(mobile): allow several new-task drafts per project by @juliusmarminge in pingdotgg/t3code#10327 * fix(mobile): slide settled threads out before collapsing by @StiensWout in pingdotgg/t3code#10345 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1303...v0.0.39-nightly.20260906.1316 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1316
Adopts upstream's manual active-thread ordering (pingdotgg#9729) in place of the fork's own implementation, per Sheehan's call. The decider now emits upstream's `thread.meta-updated` with `activeOrderKey` and its guards (reject deleted/pinned/settled, retain the snooze slot, leave updatedAt alone). The fork's `thread.active-reordered` event is no longer emitted, but its schema, projector, ProjectionPipeline and client reducer cases are deliberately RETAINED: shipped fork databases contain those events and replay must keep decoding them. Conflict resolutions worth remembering: - ProjectionSnapshotQuery: upstream's new `getTurnStartMessage` SELECT omitted the fork's message-correction columns that the shared row schema requires, so every turn start failed to decode (`MissingKey`) and took 14 orchestration tests with it. Added original_text, correction_target_message_id, correction_replacement_text and delivery_state to the SELECT. - ProviderCommandReactor: upstream moved turn-start lookups to the projection and switched the handler to a thread SHELL, which carries only a truncated objectivePreview. The fork's Goal Continuation needs the full Objective, so it re-reads the detail on that path only. `buildSendTurnRequestForThread` also loaded the whole transcript eagerly; it now uses the shell and defers the detail read to the hand-off prelude that actually needs it (this is what upstream's "without loading old message bodies" test asserts). - ProviderRuntimeIngestion: the fork's nullable Continuation messageId flowed into upstream's non-null `getThreadMessageById`; guarded. - OpenCodeAdapter: took upstream's `textPartsByMessageId` and dropped partById/emittedTextByPartId/completedAssistantPartIds (no remaining uses), keeping the fork's turns/context-window/compaction fields. - Migrations: upstream's ProjectionThreadBranchPullRequest appended as fork id 52; upstream's ProjectionThreadsActiveOrderKey NOT registered again — it is byte-identical to the fork's already-shipped id 43. - MessagesTimeline.logic: restored the fork's checkpoint-readiness guard that upstream's relocated copy lacked, so Revert stays hidden until a checkpoint is ready; the two fork tests that drove this through the removed revertTurnCountByUserMessageId prop now build a real ready-checkpoint fixture. - threadCommands: removed duplicate ReorderActiveThreadInput/reorderActiveThread declarations left by a keep-both resolution. - Re-exported helpers upstream's Knip sweep privatized but the fork imports: activeThreadAnchorTimestampMs. - Sidebar.tsx keeps the FORK's drag-and-drop subsystem (drag-to-snooze, overlay ghost, force-settle of a running thread, sidebarActiveThreadSortOrder) over upstream's pingdotgg#9731/pingdotgg#9750 rework; upstream's Sidebar.drag.ts/motion.ts are now referenced only by their own tests. - Guard script: upstream pingdotgg#10101 deleted the client-side ThreadChangeRequestSnapshot atom the linked-PR check pointed at, so the check now follows the badge to its new server-provided source. Verification: all packages typecheck; server orchestration+persistence 603/603, client-runtime 1349/1349, contracts 393/393, web unit 4427 pass. The only web failures are the two fork Goal e2e specs, confirmed failing identically on backup/mtcode-pre-upstream-sync-20260906b. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Dragging between sections repeats the move instruction on the boundary while the dragged thread still shows its old pin. This optional follow-up to #9731 puts that feedback on the thread: → Pinned, → Active, or → Settled appears when crossing sections. The usual pin, status, and hover actions hide during dragging; reordering within a section shows no destination badge. Boundaries keep their section names and highlight.
The sortable layout, drop behavior, and movement animations are unchanged. This affects the shared web/desktop sidebar, including compact rows dragged out of Snoozed or Settled. It can be accepted or closed independently of the parent PR.
Verified with 207 focused sidebar tests, web typecheck, targeted lint, and an independent code review. React Doctor reported only existing sidebar complexity warnings. The recordings exercise pinning and unpinning on matching fixtures; the dark screenshots cover a compact Settled row moving toward Active.
Before and after — pinned thread moving into Active
Before recording — pickup, unpin, then pin again:
https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/0c102f7a0712df0e/base-drag.mp4
After recording — the same sequence with the destination cue on the row:
https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/4c317de36b39b3fc/head-drag.mp4
Compact row in dark mode — Settled to Active
The light-mode screenshots and recordings compare parent
33e70c44a3with head0186450688, using matching fixtures and viewport. They are cropped to the Pinned and Active sections. The existing compact-row evidence remains representative; these fixes do not change its presentation.Prepared with Codex.
Note
Simplify sidebar drag destination cues and add accessible
Move tobadgeSidebarDragBoundary,SidebarSectionHeader, andSidebarThreadRowduring drag operationsMacroscope summarized 85bf36e.
Note
Low Risk
UI-only sidebar drag affordances; drop logic and server commands are unchanged per the PR scope.
Overview
Sidebar drag-and-drop feedback moves from repeated boundary hints onto the dragged row, with boundaries kept as section names plus highlight only.
Row behavior: When a drag crosses into a different section (pinned, active, or settled—not snoozed), the active row shows a → Pinned / Active / Settled badge with an accessible Move to prefix. Same-section reorder shows no badge. During drag, the pin control, status/time slot, and hover actions are hidden in favor of that badge.
Boundaries & placeholders:
SidebarDragBoundary,SidebarSectionHeader, and empty-section placeholders no longer take contextual hints (e.g. “Drop to pin”); labels are static section names.dropSectionis typed to exclude snoozed.Docs:
thread-sidebar.mddescribes the new cues and that reordering within a section does not show a destination badge.Reviewed by Cursor Bugbot for commit 84346fb. Bugbot is set up for automated code reviews on this repo. Configure here.