Lint all the files#210
Merged
Merged
Conversation
which is more general than just ignoring `node_modules`
for all git-tracked text files, assert that: - No trainling whitespaces at EOLs - No tab characters - a newline at EOF
so that the `lint.yml` workflow passes
that now read files that include newline at EOF
and group "lint markdown files" steps into one for clarity
etpinard
force-pushed
the
lint-all-the-files
branch
from
June 27, 2023 20:54
5fa20c7 to
18e91c4
Compare
Collaborator
Author
|
One integration test is failing
but I can't reproduce the failure locally. Since I would like to not block this PR, I'll go ahead and merge it right now. I'll attempt to fix the CI failure in a future PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to eventually follow a Julia style guide like https://github.com/SciML/SciMLStyle, but this PR should be a step in the right direction 😏