Conversation
these were moved to `DashBase.jl` during the DashBase v1 push
these are now in `DashBase.jl` since DashBase v1. This makes PlotlyBase no longer a `Dash.jl` dep! Requires is also no longer needed in `Dash.jl`
which includes the DashBase "weakdeps" so that we can test plotly graph rendering via the `DashBase` extensions. since the dash test driver uses `julia --project` as base command, we must `cd` into `test/integration` and setup `Dash` as a dev package manually. Update the dev docs accordingly!
same version used in `plotly/dash`
Update CircleCI browser tools to `1.4.3`
Even better contributing guidelines
Adapt for DashBase v1
Drop DashBase `0.2` compat
github-actions
Bot
added
documentation
Collaborator
Author
|
Requesting approval from @waralexrom or @alexcjohnson - thanks!! |
alexcjohnson
approved these changes
Oct 10, 2023
alexcjohnson
left a comment
alexcjohnson
left a comment
Contributor
There was a problem hiding this comment.
💃 Certainly cleaner this way! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
DashBase.to_dashdefinitions andgetindex(::DashBase.Component, #= =#)to DashBase (see DashBasev1 milestone, removing type piracy from the Dash.jlsrcand removing dependencies on PlotlyBase and Requires [Adapt for DashBase v1 #223, Drop DashBase0.2compat #226]Internal
Tests
1.4.3#224]Docs