Skip to content

migrate to JSON3#2

Merged
etpinard merged 1 commit into
plotly:masterfrom
sjkelly:sjk/json3
Mar 13, 2023
Merged

migrate to JSON3#2
etpinard merged 1 commit into
plotly:masterfrom
sjkelly:sjk/json3

Conversation

@sjkelly

@sjkelly sjkelly commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

This should avoid downstream Dash.jl depending on JSON, JSON2, and JSON3.

This should be released as v0.2 to avoid downstream regressions.

This should avoid downstream Dash.jl depending on JSON, JSON2, and JSON3.
@etpinard

etpinard commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Thanks very much for this PR! This looks good to me.

I can confirm that the DashBase.jl tests pass off this branch and that the Dash.jl tests also pass with this DashBash.jl ] dev'ed. ✔️

Unfortunately, I do not have merge rights for this repo, so I'll ping @alexcjohnson and @waralexrom

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Unfortunately, I do not have merge rights for this repo

Invited, I'll let you do the merge 😎

@etpinard
etpinard merged commit 237bc72 into plotly:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants