Skip to content

Column visibility#200

Closed
Farkites wants to merge 6 commits into
plotly:devfrom
Farkites:enable-column-visible
Closed

Column visibility#200
Farkites wants to merge 6 commits into
plotly:devfrom
Farkites:enable-column-visible

Conversation

@Farkites

Copy link
Copy Markdown
Contributor
  • Adds columnVisible prop and onColumnVisible event.

When using the enterprise tool panel to show/hide a column the columnVisible prop is updated with a list of dictionaries with all the columns and their visibility state.

@BSd3v

BSd3v commented May 26, 2023

Copy link
Copy Markdown
Collaborator

Hello @Farkites,

What is your thinking on this, why cant you use the columnState for this? This information should be listed there.

@Farkites

Copy link
Copy Markdown
Contributor Author

Hello @BSd3v, I guess that the only advantage of this approach is that this columnVisible property is only modified when hiding/showing columns whereas columnState gets triggered with many different events.

This can anyways be handled in the callback in all the use cases I can think of right now... Additionally, as shown in the test, my approach times out in some tests, so this approach is just slowing down the component.

Thanks for the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants