Skip to content

fix: make devtools text visible with dark themes#1664

Merged
alexcjohnson merged 2 commits into
plotly:devfrom
AnnMarieW:devtools-dark-theme
Jun 8, 2021
Merged

fix: make devtools text visible with dark themes#1664
alexcjohnson merged 2 commits into
plotly:devfrom
AnnMarieW:devtools-dark-theme

Conversation

@AnnMarieW

@AnnMarieW AnnMarieW commented Jun 4, 2021

Copy link
Copy Markdown
Collaborator

This is the revised #1659 PR

Fixes #1649 - makes the devtools readable with a dark theme.

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @AnnMarieW - I think I like the new font color better even with a light theme 🎉

@alexcjohnson alexcjohnson merged commit e5583bd into plotly:dev Jun 8, 2021
@AnnMarieW

Copy link
Copy Markdown
Collaborator Author

I thought you might like it - the font color is from @chriddyp 's stylesheet 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dash dev tools poor contrast with dark themes

3 participants