Use julia --project in JuliaRunner#2573
Merged
alexcjohnson merged 3 commits intoJun 27, 2023
Merged
Conversation
instead of just `julia` to support testing within Julia environments.
alexcjohnson
approved these changes
Jun 22, 2023
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Please add a changelog entry and we'll merge :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
JuliaRunnerspawns a Dash.jl server using thejuliaexecutable with no option. This means theJuliaRunnerexpects the Julia test dependencies to be installed in the default environment, located e.g. in~/.julia/environments/v1.9/.While installing the Julia test dependencies in the default environment might be ok in a test container, it is not the recommended way to develop Julia packages.
Using the
julia --projectin the server-spawning command, makes theJuliaRunneruse the test dependencies from the Dash.jl package environment, the same test dependencies we used in the Dash.jl unit tests.Contributor Checklist
optionals
CHANGELOG.md