Conversation
Visual snapshots are now captured locally by dash.testing (real browser screenshots into NITPIX_SNAPSHOT_DIR, one PNG per width) and diffed in CI by plotly/nitpix: baselines live on the nitpix-baselines orphan branch, PRs get a review comment with before/after/diff images and a nitpix/visual commit status, and changes are approved by commenting "/nitpix approve" — no test-matrix re-run needed. - dash/testing/browser.py: percy_snapshot() keeps its name and signature (public API) but saves PNGs locally instead of calling the Percy SDK. convert_canvases is now a no-op: real screenshots capture canvases. - testing.yml: drop PERCY_* env, percy-exec wrapper and percy-finalize; snapshot-producing jobs (test-main, html-test, dcc-test, 3.12 leg only) upload nitpix-snapshots-* artifacts instead. - nitpix.yml (new): workflow_run diff/report job in base-repo context, so fork and Dependabot PRs are fully supported — the old percy/dash placeholder-status hack in post-test-status.yml is removed. - nitpix-approve.yml (new): handles /nitpix approve comments. - table-visual-test still uses percy-storybook (separate token/mechanism); converting it is a follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual snapshots are now captured locally by dash.testing (real browser screenshots into NITPIX_SNAPSHOT_DIR, one PNG per width) and diffed in CI by plotly/nitpix: baselines live on the nitpix-baselines orphan branch, PRs get a review comment with before/after/diff images and a nitpix/visual commit status, and changes are approved by commenting "/nitpix approve" — no test-matrix re-run needed.