Skip to content

Configure de client version#24

Merged
ndrezn merged 4 commits into
mainfrom
configure-de-client-version
Sep 17, 2024
Merged

Configure de client version#24
ndrezn merged 4 commits into
mainfrom
configure-de-client-version

Conversation

@ndrezn

@ndrezn ndrezn commented Sep 17, 2024

Copy link
Copy Markdown
Member
  • Add flag to configure de-client version
  • Bump de-client to 1.8.2

@ndrezn ndrezn requested a review from emilykl September 17, 2024 14:45
@emilykl

emilykl commented Sep 17, 2024

Copy link
Copy Markdown

Oof, good catch.

Can we please make it default to the latest version, and only pin it as a last resort if we discover a breaking issue?

@halemade

Copy link
Copy Markdown

A customer's pipelines broke on Friday because of the graphql-core update, major bonus points if we can merge this soon so they're unblocked. Thank you both!

@emilykl emilykl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx @ndrezn

@ndrezn ndrezn merged commit 9b72dfa into main Sep 17, 2024
@ndrezn ndrezn deleted the configure-de-client-version branch September 17, 2024 18:20
ndrezn added a commit that referenced this pull request Sep 17, 2024
ndrezn added a commit that referenced this pull request Sep 17, 2024
@ndrezn ndrezn restored the configure-de-client-version branch September 17, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants