Skip to content

ci: Add CI step to check if precompiled regl shaders need to be updated#7786

Open
camdecoster wants to merge 6 commits into
masterfrom
cam/7785/check-regl-ci
Open

ci: Add CI step to check if precompiled regl shaders need to be updated#7786
camdecoster wants to merge 6 commits into
masterfrom
cam/7785/check-regl-ci

Conversation

@camdecoster
Copy link
Copy Markdown
Contributor

@camdecoster camdecoster commented Apr 30, 2026

Description

Add a CI step to check if precompiled regl shaders need to be updated.

Closes #7785.

Changes

  • Update CI workflow
  • Update instructions to reflect new process

Testing

  • Create a draft PR that changes one of the files that would affect the shaders
  • Review the workflow run

Notes

  • This is currently a manual process and this (mostly) automates it

@camdecoster camdecoster self-assigned this Apr 30, 2026
@camdecoster camdecoster marked this pull request as ready for review May 20, 2026 20:27
Comment thread .github/workflows/ci.yml
Comment on lines +46 to +47
# stackgl_modules/ is listed here too because the regl-* shader libs live there;
# changes can alter shader output and require regenerating the precompiled shaders.
Copy link
Copy Markdown
Contributor

@emilykl emilykl May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an additional line of explanation (feel free to adjust if not accurate)

Suggested change
# stackgl_modules/ is listed here too because the regl-* shader libs live there;
# changes can alter shader output and require regenerating the precompiled shaders.
# If any of the directories listed below have changed, we need to re-run the regl-codegen step
# stackgl_modules/ is listed here too because the regl-* shader libs live there;
# changes can alter shader output and require regenerating the precompiled shaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add CI step to check if precompiled regl shaders need to be updated

2 participants