Skip to content

feat: SASL (SCRAM-SHA-256) authentication#631

Open
rkrishn7 wants to merge 10 commits into
postgresml:mainfrom
rkrishn7:feat/sasl-authentication
Open

feat: SASL (SCRAM-SHA-256) authentication#631
rkrishn7 wants to merge 10 commits into
postgresml:mainfrom
rkrishn7:feat/sasl-authentication

Conversation

@rkrishn7

@rkrishn7 rkrishn7 commented Oct 30, 2023

Copy link
Copy Markdown

This PR implements SCRAM-SHA-256 SASL mechanism for client <> proxy authentication

Notes for reviewer:

  • I tried to keep the PR focused and not do too much refactoring. There's definitely opportunity to follow a similar pattern for MD5 authentication and consolidate some code from the scram module. However, it may be best to sequence it out into subsequent PRs for review purposes

Open Questions:

  • The current config setup allows for individual pools to override the general auth config. I wasn't quite sure if this makes sense. Completely open to other ideas

Closes #624

@rkrishn7 rkrishn7 force-pushed the feat/sasl-authentication branch from d0d2e6b to 9882137 Compare October 30, 2023 03:43
@levkk

levkk commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Thank you for this. I'll review it asap.

@rkrishn7

rkrishn7 commented Dec 1, 2023

Copy link
Copy Markdown
Author

Hey @levkk! Just checking back in here. Do you have an idea of when you'll be able to get to this? Thanks!

@levkk

levkk commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Hi. Thank you for the PR. I haven't forgotten about it, I'll try to review it sometime this weekend or early next week. Please feel free to ping me again if I don't get back to you by then.

@ConstBur

Copy link
Copy Markdown

Hi @levkk and @rkrishn7, got any news for this one?

@Neustradamus

Copy link
Copy Markdown

@rkrishn7: Nice!

Any progress on this PR?

Linked to:

@adriangb

Copy link
Copy Markdown
Contributor

Hi! This would be a really nice feature, ➕1 to get this in. Thank you to author and reviewers.

@mingjunyang

Copy link
Copy Markdown

Hi, All my PostgreSQL database baseline the scram-sha-256, this feature very useful.

@RiverPhillips

Copy link
Copy Markdown

This would be really helpful. Apologies for the ping @levkk but have you been able to review this yet?

@RiverPhillips

Copy link
Copy Markdown

I tried building this PR and testing it and ran into an error when actually using scram-sha-256 on this line here. I think it needs a little more work to get this working with the existing implementation in auth_passthrough.rs

@semoal

semoal commented May 19, 2024

Copy link
Copy Markdown

Sorry for pinging, but this is the only feature missing for us to migrate our entire stack to pgcat instead of pgbouncer

@luss

luss commented May 19, 2024 via email

Copy link
Copy Markdown

@levkk

levkk commented May 19, 2024

Copy link
Copy Markdown
Contributor

Working on 2.0 as we speak. Will have some more news soon.

@AndrewJackson2020

Copy link
Copy Markdown
Contributor

Sorry for pinging, but this is the only feature missing for us to migrate our entire stack to pgcat instead of pgbouncer

Same here with me. pgcat has some very useful features that are a huge advantage over pgbouncer but pgbouncer has a lot more options on the auth front. scram-sha-256 is a huge piece of that and would love to see it included in pcat. Has there been any progress on this PR?

@SoulKyu

SoulKyu commented Jan 10, 2025

Copy link
Copy Markdown

Any news on this MR ?

@kabir-bitstack

kabir-bitstack commented Feb 1, 2025

Copy link
Copy Markdown

@levkk Any news on this?

SASL is highly recommended.

Also, this would allow running pgcat with auth_query as a proxy.

@ramilmsh

Copy link
Copy Markdown

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: SASL client support