Fix tx_id mismatch for insert-only tables - #214
Merged
Conversation
simolus3
marked this pull request as ready for review
August 13, 2026 09:04
rkistner
approved these changes
Aug 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crud vtab is responsible for incrementing recorded
tx_idvalues in transactions. We have two of them though, and both would increment the transaction counter for transactions on both vtabs (for regular and insert-only tables).This fixes the issue by only incrementing
tx_idif we're not already known to be in a transaction.This also reformats Dart sources with the formatter from 3.13.
AI use: Manually written, then reviewed with Claude Code and used for trivial style improvements.