perf: Refactored sorting to use optimized sort algorithms#2161
Open
dhoard wants to merge 2 commits into
Open
Conversation
Signed-off-by: dhoard <doug.hoard@gmail.com>
dhoard
changed the title
zeitlinger
reviewed
May 29, 2026
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
Great - only wonder if this could be re-usable. Either generics or generating code code.
| * <p>Uses 3-way quicksort partitioning for large ranges, insertion sort for tiny ranges, and a | ||
| * heapsort fallback at the recursion-depth limit to guarantee O(n log n) worst-case complexity. | ||
| */ | ||
| private static final class StringArraySorter { |
Member
There was a problem hiding this comment.
looks pretty similar to last sorter - can we use generics or would this break perf?
Collaborator
Author
There was a problem hiding this comment.
Most likely. I chose to keep the code isolated like the Bubble sort implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to use optimized sort algorithms.