Update rules_rust to 1.69.0, rust to 1.93.1. - #496
Merged
Conversation
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
February 26, 2026 20:35
PiotrSikora
requested changes
Feb 26, 2026
PiotrSikora
reviewed
Feb 26, 2026
PiotrSikora
left a comment
PiotrSikora
left a comment
Member
There was a problem hiding this comment.
You need to regenerate crates (use bazelisk run //bazel/cargo/wasmsign:crates_vendor without arguments to avoid updating dependencies, since that's going to pollute PR).
PiotrSikora
reviewed
Feb 27, 2026
PiotrSikora
reviewed
Feb 27, 2026
PiotrSikora
changed the title
leonm1
force-pushed
the
update/rust
branch
2 times, most recently
from
March 2, 2026 13:49
bd743c0 to
90881fe
Compare
This was referenced Mar 2, 2026
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This reverts commit c19e738. Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
enabled auto-merge (squash)
March 2, 2026 19:23
leonm1
added a commit
that referenced
this pull request
Mar 12, 2026
Always uses prefixed wasmtime-c-api-impl, otherwise the prefixed implementation bitrots. Prefixes the headers in the repo rule to allow for globbing, which is not possible in a genrule. The crates_vendor-provided wasmtime-c-api-impl provided build allows us to upgrade wasmtime solely by changing the version number in the repositories.bzl and Cargo.toml files. Build off of #496 --------- Signed-off-by: Matt Leon <mattleon@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.