Skip to content

libHttp changes#97

Merged
miigotu merged 3 commits into
ps3dev:masterfrom
bucanero:http-changes
Jul 2, 2020
Merged

libHttp changes#97
miigotu merged 3 commits into
ps3dev:masterfrom
bucanero:http-changes

Conversation

@bucanero

Copy link
Copy Markdown

As mentioned in #89 , current libhttp methods don't work properly.

This is a proposed patch, tested and working on real ps3 hardware.

bucanero added 2 commits June 30, 2020 12:27
Used changes from Estwald v2 sdk
(http connections were failing due to wrong typedefs)
ppu/sprx/libhttp/exports.h
@dee12452

dee12452 commented Jul 1, 2020

Copy link
Copy Markdown

If the ps3 VSH exports list says these use size_t, would it be better to use u32 instead of s32? I feel like any time a param has the word "size" in it, it's not usually a negative value.

@miigotu

miigotu commented Jul 1, 2020

Copy link
Copy Markdown
Member

@dee12452 correct, most of these are all ppolsize, maxsize, etc which would all be positive integers.
@bucanero can you try switching them to u32? s32 probably doesnt make a difference but u32 would be the proper cast.

Edit: actually uint32_t

@bucanero

bucanero commented Jul 1, 2020

Copy link
Copy Markdown
Author

yes, I agree, it seems better to use unsigned uint32_t for all the size_t parameters. I'll change it and test again.

btw, any preference between u32 and uint32_t in PSL1GHT? I guess I've seen both used so not sure which one is the preferred one.

@dee12452

dee12452 commented Jul 1, 2020

Copy link
Copy Markdown

From looking through the code, it looked to me like u32 was being used more often
edit: thought you wrote performance, not preference... lol

@miigotu

miigotu commented Jul 1, 2020

Copy link
Copy Markdown
Member

I personally would go with whatever convention is used in each file. That's why I said uint32_t in this case because those files seem to use that stdint types the most.

@bucanero

bucanero commented Jul 1, 2020

Copy link
Copy Markdown
Author

I personally would go with whatever convention is used in each file. That's why I said uint32_t in this case because those files seem to use that stdint types the most.

I tested again the http/https methods using u32 and everything works ok. 👍

I followed @miigotu criteria, and used u32 in files where they are using s32 already, and used uint32_t in ssl.h where they're using the uintX_t style.

@miigotu miigotu merged commit f6bbaf3 into ps3dev:master Jul 2, 2020
@bucanero bucanero deleted the http-changes branch July 2, 2020 15:49
miigotu pushed a commit that referenced this pull request Jul 3, 2020
* Fixed http typedefs

Used changes from Estwald v2 sdk
(http connections were failing due to wrong typedefs)

* Fix definitions to match exports.h

ppu/sprx/libhttp/exports.h

* Change size_t to u32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants