Skip to content

Min and Max should have type Number #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paf31 merged 1 commit into from
May 4, 2018
Merged

Min and Max should have type Number #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codegen/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ const types = {
"hidden": "Boolean",
"itemScope": "Boolean",
"loop": "Boolean",
"max": "Number",
"min": "Number",
"multiple": "Boolean",
"muted": "Boolean",
"noValidate": "Boolean",
Expand Down Expand Up @@ -64,4 +66,3 @@ props.elements.html
}
`;
}).forEach((x) => console.log(x.replace(/^\n\ {4}/, "").replace(/\n\ {4}/g, "\n")))

8 changes: 4 additions & 4 deletions generated-docs/React/Basic/DOM.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ img :: forall attrs attrs_. Union attrs attrs_ (SharedProps Props_img) => { | a
#### `Props_input`

``` purescript
type Props_input = (accept :: String, alt :: String, autoCapitalize :: String, autoCorrect :: String, autoSave :: String, checked :: Boolean, defaultChecked :: String, defaultValue :: String, disabled :: Boolean, form :: String, height :: String, list :: String, max :: String, min :: String, multiple :: Boolean, name :: String, onChange :: EventHandler, pattern :: String, placeholder :: String, required :: Boolean, results :: String, size :: Number, src :: String, step :: String, title :: String, "type" :: String, value :: String, width :: String)
type Props_input = (accept :: String, alt :: String, autoCapitalize :: String, autoCorrect :: String, autoSave :: String, checked :: Boolean, defaultChecked :: String, defaultValue :: String, disabled :: Boolean, form :: String, height :: String, list :: String, max :: Number, min :: Number, multiple :: Boolean, name :: String, onChange :: EventHandler, pattern :: String, placeholder :: String, required :: Boolean, results :: String, size :: Number, src :: String, step :: String, title :: String, "type" :: String, value :: String, width :: String)
```

#### `input`
Expand Down Expand Up @@ -1205,7 +1205,7 @@ meta :: forall attrs attrs_. Union attrs attrs_ (SharedProps Props_meta) => { |
#### `Props_meter`

``` purescript
type Props_meter = (children :: Array JSX, high :: String, low :: String, max :: String, min :: String, optimum :: String, value :: String)
type Props_meter = (children :: Array JSX, high :: String, low :: String, max :: Number, min :: Number, optimum :: String, value :: String)
```

#### `meter`
Expand Down Expand Up @@ -1415,7 +1415,7 @@ pre_ :: Array JSX -> JSX
#### `Props_progress`

``` purescript
type Props_progress = (children :: Array JSX, max :: String, value :: String)
type Props_progress = (children :: Array JSX, max :: Number, value :: String)
```

#### `progress`
Expand Down Expand Up @@ -2069,7 +2069,7 @@ var_ :: Array JSX -> JSX
#### `Props_video`

``` purescript
type Props_video = (children :: Array JSX, controls :: Boolean, height :: String, loop :: Boolean, muted :: Boolean, poster :: String, preload :: String, src :: String, width :: String)
type Props_video = (children :: Array JSX, controls :: Boolean, height :: String, loop :: Boolean, muted :: Boolean, playsInline :: Boolean, poster :: String, preload :: String, src :: String, width :: String)
```

#### `video`
Expand Down
11 changes: 6 additions & 5 deletions src/React/Basic/DOM.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,8 +902,8 @@ type Props_input =
, form :: String
, height :: String
, list :: String
, max :: String
, min :: String
, max :: Number
, min :: Number
, multiple :: Boolean
, name :: String
, onChange :: EventHandler
Expand Down Expand Up @@ -1141,8 +1141,8 @@ type Props_meter =
( children :: Array JSX
, high :: String
, low :: String
, max :: String
, min :: String
, max :: Number
, min :: Number
, optimum :: String
, value :: String
)
Expand Down Expand Up @@ -1330,7 +1330,7 @@ pre_ children = pre { children }

type Props_progress =
( children :: Array JSX
, max :: String
, max :: Number
, value :: String
)

Expand Down Expand Up @@ -2141,6 +2141,7 @@ type Props_video =
, height :: String
, loop :: Boolean
, muted :: Boolean
, playsInline :: Boolean
, poster :: String
, preload :: String
, src :: String
Expand Down