Skip to content

Bug: clean up gettext output folder before updating po files #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flpm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug: clean up gettext output folder before updating po files #779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c76113
clean up gettext output folder before updating po files
flpm Jul 29, 2026
7292c62
Merge branch 'main' into fix-small-bug-in-update-languages
flpm Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ def update_release_languages(session):
if RELEASE_LANGUAGES:
session.install("-e", ".")
session.install("sphinx-intl")
_clean_translation_templates(session)
session.log("Updating templates (.pot)")
session.run(
SPHINX_BUILD,
Expand Down Expand Up @@ -298,6 +299,7 @@ def update_language(session):
if lang in LANGUAGES:
session.install("-e", ".")
session.install("sphinx-intl")
_clean_translation_templates(session)
session.log("Updating templates (.pot)")
session.run(
SPHINX_BUILD,
Expand Down Expand Up @@ -427,6 +429,20 @@ def build_all_languages_test(session):
session.notify("build-all-languages", [*TEST_PARAMETERS])


def _clean_translation_templates(session) -> None:
"""
Remove the gettext output directory before regenerating the templates (.pot).

The gettext build is incremental and never deletes a .pot whose source page is
gone, while `sphinx-intl update` creates a .po for every .pot it finds. Without
this, a page that briefly existed in the source tree leaves an orphan .pot
behind, and every later update spawns a matching .po in each locale.
"""
if TRANSLATION_TEMPLATE_DIR.exists():
session.log(f"Cleaning out {TRANSLATION_TEMPLATE_DIR}")
shutil.rmtree(TRANSLATION_TEMPLATE_DIR)


def _sphinx_env(session) -> str:
"""
Get the sphinx env, from the first positional argument if present or from the
Expand Down
Loading