fix(client): retain failed thread-load diagnostics - #286
Merged
Conversation
Manually port upstream #10216 (bd16b86d50c1df49afeb7c0a7568a4908ade4048) to Pylon subscription handling. Preserve rollback and pagination capabilities and keep deletion authoritative after stream failure.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread load could terminate during initialization or protocol handling without retaining a useful diagnostic. Later connection notifications or buffered events could erase the failure even though no new load had begun.
Observe the complete subscription attempt and retain a generic diagnostic until an actual retry starts. Preserve transport/domain recovery, fatal-defect behavior, deletion precedence, and Pylon's rollback and pagination handling. This manually adapts upstream #10216, bd16b86d50c1df49afeb7c0a7568a4908ade4048, without importing its unrelated subscription architecture.
Validation: 49 focused RPC, thread failure, synchronization, pagination, and atom tests passed. Shared client-runtime and mobile typechecks, targeted lint, format, and diff checks passed. The shared state applies across providers and connection modes. Existing uncached mobile error UI can display the diagnostic; this does not add web/desktop error presentation or restart providers.
Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.