fix(server): dismiss native questions after their turn ends - #297
Merged
Conversation
(cherry picked from commit d7fe47fd0957a34fc2e8bb05f12db19bac3403b6)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a native provider turn ended with an unanswered question, the thread could retain a pending-input form that could no longer receive an answer. Resolve unanswered native questions for the exact terminal turn, including completed, failed, interrupted and aborted outcomes.
Adopts approved B5, upstream #9851, d7fe47fd0957a34fc2e8bb05f12db19bac3403b6. Uses Pylon’s existing guarded dispatch, session-incarnation checks and drainable worker. Prime interaction records, answered questions, other turns and explicitly stored message-mode activities are preserved. Does not import upstream’s separate async-question API. Applies to all native providers and every client/connection mode.
Validation: 91 focused ingestion tests pass, including duplicate terminal events, all terminal outcomes, answered/newer/child requests and a retired session attempting to clear a current session’s question. Server typecheck, targeted lint and diff checks pass. Tests use isolated in-memory persistence and worker drains.
Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.