Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/mobile/src/features/threads/NewTaskDraftScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ export function NewTaskDraftScreen(props: {
multiline
scrollEnabled
value={flow.prompt}
skills={flow.selectedProviderStatus?.skills ?? []}
skills={composerMenu.skills}
selection={composerMenu.selection}
onChangeText={flow.setPrompt}
onSelectionChange={composerMenu.onSelectionChange}
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1744,7 +1744,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
// keystroke makes resolveTranscriptCommit see a changed draft and
// discard the whole transcript as stale.
readOnly={voiceInput.freezesEditor}
skills={selectedProviderStatus?.skills ?? []}
skills={composerMenu.skills}
selection={composerMenu.selection}
onChangeText={props.onChangeDraftMessage}
onSelectionChange={composerMenu.onSelectionChange}
Expand Down
17 changes: 10 additions & 7 deletions apps/mobile/src/features/threads/ThreadDetailScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type { EnvironmentThreadStatus } from "@t3tools/client-runtime/state/thre
import { isRollbackActive, type RollbackTarget } from "@t3tools/client-runtime/rollback";
import { getMobileRollbackStatusPresentation } from "./rollback-status-presentation";
import { useKeyboardChatComposerInset, useKeyboardScrollToEnd } from "@legendapp/list/keyboard";
import { resolveProviderSkillsForCwd } from "@t3tools/client-runtime/providerSkills";
import type { LegendListRef } from "@legendapp/list/react-native";
import { HeaderHeightContext } from "@react-navigation/elements";
import type {
Expand Down Expand Up @@ -643,12 +644,14 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
const contentMaxWidth = isSplitLayout ? CHAT_CONTENT_MAX_WIDTH : undefined;
const selectedInstanceId = props.selectedThread.modelSelection.instanceId;
useStreamingHaptics(props.selectedThread.id, props.selectedThreadFeed);
const selectedProviderSkills = useMemo(
() =>
props.serverConfig?.providers.find((provider) => provider.instanceId === selectedInstanceId)
?.skills ?? [],
[props.serverConfig, selectedInstanceId],
);
const selectedProviderSkills = useMemo(() => {
const provider = props.serverConfig?.providers.find(
(candidate) => candidate.instanceId === selectedInstanceId,
);
return provider
? resolveProviderSkillsForCwd(provider, props.threadCwd ?? props.projectWorkspaceRoot)
: [];
}, [props.projectWorkspaceRoot, props.serverConfig, props.threadCwd, selectedInstanceId]);
const aboveEditorWidgets = useMemo(
() =>
props.sessionInteractionPresentation.widgets.filter(
Expand Down Expand Up @@ -1044,7 +1047,7 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
props.rollbackStatus?.state === "manual-recovery"
}
environmentId={props.environmentId}
projectCwd={props.projectWorkspaceRoot}
projectCwd={props.threadCwd ?? props.projectWorkspaceRoot}
bottomInset={hasBelowEditorWidgets ? 0 : composerBottomInset}
onChangeDraftMessage={props.onChangeDraftMessage}
onPickDraftMedia={props.onPickDraftMedia}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ import { describe, expect, it, vi } from "vite-plus/test";
vi.mock("../../state/queries", () => ({
useComposerPathSearch: () => ({ entries: [], isPending: false }),
}));
vi.mock("../../state/server", () => ({
serverEnvironment: { refreshProviders: Symbol("refreshProviders") },
}));
vi.mock("../../state/use-atom-command", () => ({
useAtomCommand: () => vi.fn(),
}));

import type { ComposerCommandMenuProvider } from "./use-composer-command-menu";

Expand Down
76 changes: 75 additions & 1 deletion apps/mobile/src/features/threads/use-composer-command-menu.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { useAtomCommand } from "../../state/use-atom-command";
import { serverEnvironment } from "../../state/server";
import {
resolveProviderSkillsForCwd,
dedupeProviderSkillsByName,
getProviderSkillsForSlashMenu,
getProviderSlashCommandsForSlashMenu,
Expand Down Expand Up @@ -34,6 +37,8 @@ import { useComposerPathSearch } from "../../state/queries";
import type { ComposerCommandItem } from "./ComposerCommandPopover";
import { matchesSlashSkillQuery } from "./composerSlashSkillSearch";

const WORKSPACE_SNAPSHOT_RETRY_COOLDOWN_MS = 10_000;

/**
* The slice of a provider snapshot the menu reads. Narrower than `ServerProvider`
* so the pure builder can be exercised without a full status fixture.
Expand Down Expand Up @@ -336,6 +341,71 @@ export function useComposerCommandMenu({
setSelection(composerSelectionAtEnd(draftMessage));
}, [draftMessage, ownerKey]);

const skills = useMemo(
() =>
selectedProviderStatus ? resolveProviderSkillsForCwd(selectedProviderStatus, projectCwd) : [],
[projectCwd, selectedProviderStatus],
);
const refreshProviders = useAtomCommand(serverEnvironment.refreshProviders, {
reportFailure: false,
});
const selectedProviderInstanceId = selectedProviderStatus?.instanceId;
const hasWorkspaceSnapshot = Boolean(
projectCwd &&
selectedProviderStatus?.workspaceSnapshots?.some((snapshot) => snapshot.cwd === projectCwd),
);
const workspaceRefreshKeyRef = useRef<string | null>(null);
const workspaceRefreshRetryRef = useRef<{ key: string; notBefore: number } | null>(null);
const hadWorkspaceSnapshotRef = useRef(false);
useEffect(() => {
if (hadWorkspaceSnapshotRef.current && !hasWorkspaceSnapshot) {
workspaceRefreshKeyRef.current = null;
workspaceRefreshRetryRef.current = null;
}
hadWorkspaceSnapshotRef.current = hasWorkspaceSnapshot;
}, [hasWorkspaceSnapshot]);
useEffect(() => {
if (!environmentId || !projectCwd || !selectedProviderInstanceId) return;
const key = `${environmentId}:${selectedProviderInstanceId}:${projectCwd}`;
if (workspaceRefreshKeyRef.current === key) return;
if (hasWorkspaceSnapshot) {
workspaceRefreshKeyRef.current = key;
workspaceRefreshRetryRef.current = null;
return;
}
const retry = workspaceRefreshRetryRef.current;
if (retry?.key === key && Date.now() < retry.notBefore) return;
workspaceRefreshKeyRef.current = key;
const retryLater = () => {
if (workspaceRefreshKeyRef.current !== key) return;
workspaceRefreshKeyRef.current = null;
workspaceRefreshRetryRef.current = {
key,
notBefore: Date.now() + WORKSPACE_SNAPSHOT_RETRY_COOLDOWN_MS,
};
};
void refreshProviders({
environmentId,
input: { instanceId: selectedProviderInstanceId, cwd: projectCwd },
}).then((result) => {
const refreshed =
result._tag === "Success" &&
result.value.providers
.find((provider) => provider.instanceId === selectedProviderInstanceId)
?.workspaceSnapshots?.some((snapshot) => snapshot.cwd === projectCwd);
if (!refreshed && workspaceRefreshKeyRef.current === key) {
retryLater();
}
}, retryLater);
}, [
draftMessage,
environmentId,
hasWorkspaceSnapshot,
projectCwd,
refreshProviders,
selectedProviderInstanceId,
]);

const trigger = useMemo<ComposerTrigger | null>(() => {
if (!enabled || selection.start !== selection.end) {
return null;
Expand All @@ -358,7 +428,9 @@ export function useComposerCommandMenu({
() =>
buildComposerCommandItems({
trigger,
selectedProviderStatus,
selectedProviderStatus: selectedProviderStatus
? { ...selectedProviderStatus, skills }
: null,
providerSlashCommands,
showInteractionModeToggle:
showInteractionModeToggle && onUpdateInteractionMode !== undefined,
Expand All @@ -371,6 +443,7 @@ export function useComposerCommandMenu({
pathSearch.entries,
providerSlashCommands,
selectedProviderStatus,
skills,
showInteractionModeToggle,
trigger,
],
Expand Down Expand Up @@ -401,6 +474,7 @@ export function useComposerCommandMenu({
onSelectionChange,
trigger,
items,
skills,
isLoading: pathSearch.isPending,
onSelect,
};
Expand Down
29 changes: 19 additions & 10 deletions apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ function buildGeneratedWorktreeBranchName(raw: string): string {
}

const make = Effect.gen(function* () {
const reactorScope = yield* Effect.scope;
const crypto = yield* Crypto.Crypto;
const orchestrationEngine = yield* OrchestrationEngineService;
const projectionSnapshotQuery = yield* ProjectionSnapshotQuery;
Expand Down Expand Up @@ -857,21 +858,28 @@ const make = Effect.gen(function* () {
thread,
projects: project ? [project] : [],
});
const refreshWorkspaceSnapshot = effectiveCwd
? providerRegistry
.refreshWorkspaceSnapshot({ instanceId: desiredInstanceId, cwd: effectiveCwd })
.pipe(Effect.forkIn(reactorScope))
: Effect.void;

const startProviderSession = (input?: {
readonly resumeCursor?: unknown;
readonly provider?: ProviderDriverKind;
}) =>
providerService.startSession(threadId, {
threadId,
...(preferredProvider ? { provider: preferredProvider } : {}),
providerInstanceId: desiredInstanceId,
...(effectiveCwd ? { cwd: effectiveCwd } : {}),
...(thread.title ? { title: thread.title } : {}),
modelSelection: desiredModelSelection,
...(input?.resumeCursor !== undefined ? { resumeCursor: input.resumeCursor } : {}),
runtimeMode: desiredRuntimeMode,
});
providerService
.startSession(threadId, {
threadId,
...(preferredProvider ? { provider: preferredProvider } : {}),
providerInstanceId: desiredInstanceId,
...(effectiveCwd ? { cwd: effectiveCwd } : {}),
...(thread.title ? { title: thread.title } : {}),
modelSelection: desiredModelSelection,
...(input?.resumeCursor !== undefined ? { resumeCursor: input.resumeCursor } : {}),
runtimeMode: desiredRuntimeMode,
})
.pipe(Effect.tap(() => refreshWorkspaceSnapshot));

const bindSessionToThread = (session: ProviderSession) =>
Effect.gen(function* () {
Expand Down Expand Up @@ -1029,6 +1037,7 @@ const make = Effect.gen(function* () {
!shouldRestartForModelChange &&
!shouldRestartForModelSelectionChange
) {
yield* refreshWorkspaceSnapshot;
if (options?.pendingTurnStart === false) return activeSession;
return (yield* bindSessionToThread(activeSession!)) ? activeSession : undefined;
}
Expand Down
36 changes: 35 additions & 1 deletion apps/server/src/provider/Drivers/CodexDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ import { ServerConfig } from "../../config.ts";
import { ServerSettingsService } from "../../serverSettings.ts";
import { ProviderDriverError } from "../Errors.ts";
import { makeCodexAdapter } from "../Layers/CodexAdapter.ts";
import { checkCodexProviderStatus, makePendingCodexProvider } from "../Layers/CodexProvider.ts";
import {
checkCodexProviderStatus,
makePendingCodexProvider,
probeCodexSkillsForCwd,
} from "../Layers/CodexProvider.ts";
import { resolveCodexLaunchArgs } from "../Layers/codexLaunchArgs.ts";
import { ProviderEventLoggers } from "../Layers/ProviderEventLoggers.ts";
import { makeManagedServerProvider } from "../makeManagedServerProvider.ts";
import * as ModelManifest from "../ModelManifest.ts";
Expand Down Expand Up @@ -243,6 +248,34 @@ export const CodexDriver: ProviderDriver<CodexSettings, CodexDriverEnv> = {
}),
),
);
const snapshotForCwd = (cwd: string) =>
!effectiveConfig.enabled
? snapshot.getSnapshot
: Effect.all([
snapshot.getSnapshot,
probeCodexSkillsForCwd({
binaryPath: effectiveConfig.binaryPath,
homePath: effectiveConfig.homePath,
launchArgs: resolveCodexLaunchArgs(effectiveConfig.launchArgs, processEnv),
cwd,
environment: processEnv,
}).pipe(
Effect.scoped,
Effect.timeout("20 seconds"),
Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner),
),
]).pipe(
Effect.map(([machineSnapshot, skills]) => ({ ...machineSnapshot, skills })),
Effect.mapError(
(cause) =>
new ProviderDriverError({
driver: DRIVER_KIND,
instanceId,
detail: `Failed to probe Codex skills for '${cwd}'`,
cause,
}),
),
);

return {
instanceId,
Expand All @@ -252,6 +285,7 @@ export const CodexDriver: ProviderDriver<CodexSettings, CodexDriverEnv> = {
accentColor,
enabled,
snapshot,
snapshotForCwd,
adapter,
textGeneration,
} satisfies ProviderInstance;
Expand Down
20 changes: 20 additions & 0 deletions apps/server/src/provider/Drivers/CursorDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import {
makeProviderSnapshotSettingsSource,
type ProviderSnapshotSettings,
} from "../providerUpdateSettings.ts";
import { probeCursorSkills } from "./CursorSkills.ts";
const decodeCursorSettings = Schema.decodeSync(CursorSettings);

const DRIVER_KIND = ProviderDriverKind.make("cursor");
Expand Down Expand Up @@ -195,6 +196,25 @@ export const CursorDriver: ProviderDriver<CursorSettings, CursorDriverEnv> = {
accentColor,
enabled,
snapshot,
snapshotForCwd: (cwd) =>
!effectiveConfig.enabled
? snapshot.getSnapshot
: Effect.all([
snapshot.getSnapshot,
probeCursorSkills(cwd, processEnv).pipe(
Effect.provideService(FileSystem.FileSystem, fileSystem),
Effect.provideService(Path.Path, path),
Effect.mapError(
(cause) =>
new ProviderDriverError({
driver: DRIVER_KIND,
instanceId,
detail: `Failed to discover Cursor skills for '${cwd}'`,
cause,
}),
),
),
]).pipe(Effect.map(([machineSnapshot, skills]) => ({ ...machineSnapshot, skills }))),
adapter,
textGeneration,
} satisfies ProviderInstance;
Expand Down
Loading
Loading