fix(server): keep large tool results from resetting live streams - #333
Merged
Merged
Conversation
Selectively adopts the live-stream portion of upstream ce4712d5b04fb998f79fe132245289191147e5d5 (#9799). Project activity payloads before retaining them and keep only aggregate identity in shell queues.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A raw 9 MiB tool result could overflow an otherwise empty live-update buffer before its small client projection was applied. Both the thread and sidebar streams then failed with “The live event buffer is full,” disrupting updates regardless of the provider.
Project thread activity before retaining it, and keep only event identity in the shell queue before refetching its current aggregate. Preserve item/byte limits, sequence ordering, completion markers, replay and genuine overflow recovery. Persisted tool output and provider execution are unchanged. Selectively adopts the live-stream portion of pingdotgg/t3code#9799, source
ce4712d5b04fb998f79fe132245289191147e5d5; the ledger identifies the portions outside this PR.Validation: the two new real-WebSocket regression cases failed against the baseline. After the fix, all 183 tests across routing, live budgets, coalescing and payload projection passed. Scoped server typecheck, changed-file lint, formatting and diff checks passed. No visible layout or native changes require screenshots.
Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.