fix(web): decide the composer strip from the controls it will draw - #438
Open
rynfar wants to merge 1 commit into
Open
fix(web): decide the composer strip from the controls it will draw#438rynfar wants to merge 1 commit into
rynfar wants to merge 1 commit into
Conversation
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #435. Substantially addresses #437.
The composer context strip decided its own visibility from
isGitRepo, whileBranchToolbardecided its Git controls fromisGitRepo && !rollbackActive.During a rollback the two disagreed: the strip stayed open because there was a
repository, and then drew nothing, leaving a visible empty bar with the shell's
clip-path extension around it.
The predicate's input was named for the repository when what it needs is what
the strip will actually draw, so it is now
showsGitControls, andChatViewderives that once and passes the same value to both the predicate and
BranchToolbar. The two can no longer disagree.While here, the mount-versus-visible pair moved out of the view into
resolveComposerContextStripVisibilityinChatView.logic.ts. That pair is thepart that has now been wrong twice — once hiding a live capacity reading (#432),
once showing an empty bar — and it was only reachable by rendering a chat. It is
now a pure function with tests covering the rollback case, the capacity case,
and the measuring strip that must stay mounted while hidden.
Not claiming #437 is closed:
ChatViewstill assembles the inputs, so cutting afield there would restore a bug with tests green. What is left is literal field
assignment rather than a decision, and covering it properly needs a ChatView
render harness, which does not exist yet.
No UI change to show: this fixes a state that renders nothing either way — an
empty bar becomes no bar. Verified by test rather than by screenshot, including
a mutation check (forcing the Git input true fails 3 tests).
Written by Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.