Skip to content

fix(web): unify PR status icons and surface the copy-link shortcut - #630

Merged
rynfar merged 6 commits into
pylonfrom
upstream/2026-09-18-pr-presentation
Sep 18, 2026
Merged

rynfar merged 6 commits into
pylonfrom
upstream/2026-09-18-pr-presentation

Conversation

@rynfar

@rynfar rynfar commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

PR status icons differed between the list, detail header, tabs and thread badges, and the copy-link shortcut was listed under Thread. Centralize lifecycle glyphs and tones, keep conflict warnings separate from lifecycle state, and group “Copy Link or Thread ID” with the PR keybindings.

Adopts oliver / flamboh's e8ca3a82806dff84438d5aba66b693468f7ca426 (#11144) and Bilal Bakr's 014016a62344ab03dbccdb73c3c1861bc4f7e349 (#11826). Original authorship and cherry-pick provenance retained. Preserve Pylon context popovers, linked-PR descriptions, provider identities and projected snapshot authority. No shortcut binding or wire behavior changes.

Direct adversarial self-review covered stale draft flags on merged/closed PRs, stack and multiple-link aggregate states, unknown-state fallbacks, conflict visibility and preserved Pylon interactions. 96 focused tests pass; web typecheck and scoped lint pass (existing warnings). Browser before/after evidence verifies the PR lifecycle glyphs and copy-link setting.

Part of #625. No release or installation.

Implemented and adversarially self-reviewed with Codex (GPT-6), without delegation at the maintainer's request.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pylon-marketing Ready Ready Preview Sep 18, 2026 3:33pm UTC

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Sep 18, 2026
@rynfar
rynfar force-pushed the upstream/2026-09-18-pr-presentation branch from e2380ab to 5c2b318 Compare September 18, 2026 15:23
@rynfar

rynfar commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Browser verification on 5c2b318: the merged PR uses consistent lifecycle glyphs in list, tab and detail; Settings → Keybindings → “copy” now groups “Copy Link or Thread ID” with “Copy Number” under Pull Request. Existing shortcuts and terminal-focus exclusions are unchanged. State precedence, conflict warnings, stack/linked aggregates and snapshot authority are covered by the 96 focused tests.

Attachments: icons before/after, keybindings before/after.

icons-before icons-after keybindings-before keybindings-after

@rynfar
rynfar merged commit 6588d50 into pylon Sep 18, 2026
20 checks passed
@rynfar
rynfar deleted the upstream/2026-09-18-pr-presentation branch September 18, 2026 15:42
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 14.0 KiB 14.0 KiB +4 B (+0.0%) 15.1 KiB
Codex Thread snapshot wire 7.2 KiB 7.2 KiB −7 B (−0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.7 KiB 6.7 KiB +11 B (+0.2%) 7.8 KiB
Codex Live turn WebSocket decoded 58.0 KiB 58.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 9 9 0 (0.0%) 21
Claude Total thread wire 14.0 KiB 14.0 KiB −13 B (−0.1%) 15.1 KiB
Claude Thread snapshot wire 7.2 KiB 7.2 KiB +15 B (+0.2%) 7.3 KiB
Claude Live turn WebSocket wire 6.8 KiB 6.7 KiB −28 B (−0.4%) 7.8 KiB
Claude Live turn WebSocket decoded 58.9 KiB 58.9 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 9 9 0 (0.0%) 21

Baseline: 6d8ebeb · PR result: 255c9e5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.7 KiB
  • Claude decoded thread snapshot: 116.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants