Skip to content

[pre-commit.ci] pre-commit autoupdate#11885

Closed
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config
Closed

[pre-commit.ci] pre-commit autoupdate#11885
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Comment thread testing/test_config.py
Comment on lines +2112 to +2114
msg = msg = (
"Defining 'pytest_plugins' in a non-top-level conftest is no longer supported"
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg = msg = (
"Defining 'pytest_plugins' in a non-top-level conftest is no longer supported"
)
msg = (
"Defining 'pytest_plugins' in a non-top-level conftest is no longer supported"
)

@nicoddemus

Copy link
Copy Markdown
Member

Unfortunately black and reorder-python-imports are no longer compatible, and from the looks of it probably will not be compatible anytime soon:

asottile/reorder-python-imports#367
asottile/reorder-python-imports#366
psf/black#4175

I'm trying out ruff in a few repos:

pytest-dev/pytest-mock#406
pytest-dev/execnet#239

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Jan 30, 2024
Unfortunately black and reorder-python-imports are no longer compatible, and from the looks of it probably will not be compatible anytime soon:

asottile/reorder-python-imports#367
asottile/reorder-python-imports#366
psf/black#4175

This replaces `reorder-python-imports` by `isort` configured in a way to yield roughtly the same results.

Closes pytest-dev#11885
@Pierre-Sassoulas
Pierre-Sassoulas deleted the pre-commit-ci-update-config branch January 31, 2024 12:57
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pytest that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants