[pre-commit] Activate ruff checks and fix existing issues

[Pierre-Sassoulas]

Follow-up to #11901, there's some nice fixes here I think, especially automated removal of useless noqa. I would consider adding flake8-bugbear next but let me know what you think. I suppose most of the f"{x!s}" are the default behavior in a f-string and we could replace them with f"{x}" but I'm not sure why this is not what ruff does when autofixing already.

[bluetech]

Nice!

👍 on bugbear (at least most of the rules).

flake8-pyi also looks very nice.

[bluetech]

I suppose most of the f"{x!s}" are the default behavior in a f-string and we could replace them with f"{x}" but I'm not sure why this is not what ruff does when autofixing already.

Probably because __format__ might not be the same as __str__ so blind replacing would not be safe. For most types it would be the same, but needs manual inspection of the type.

[Pierre-Sassoulas]

Always thought that format called __str__, TIL.