Upgrade ruff to 0.8.1 and fix existing issues#13009
Merged
Merged
Conversation
Pierre-Sassoulas
added
the
dependencies
Pierre-Sassoulas
changed the title
Pierre-Sassoulas
added
the
skip news
Pierre-Sassoulas
marked this pull request as draft
November 29, 2024 06:51
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
3 times, most recently
from
November 29, 2024 21:34
5084e1b to
6313502
Compare
Pierre-Sassoulas
marked this pull request as ready for review
November 29, 2024 21:43
nicoddemus
approved these changes
Nov 30, 2024
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks a lot @Pierre-Sassoulas for tackling this!
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
from
November 30, 2024 13:57
b35193a to
17c5bbb
Compare
Member
Author
|
Thank you for the review and tips @nicoddemus ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12875, and #12995. Lot of manual work and partial add + bissection of issues on this one. Review should be done commit by commit because there's also automated changes.