[PR #14220/680f9f3e backport][9.1.x] raises: fix stale loop variable in RaisesGroup error reporting#14620
Merged
bluetech merged 1 commit intoJun 17, 2026
Conversation
raises: fix stale loop variable in RaisesGroup error reporting (cherry picked from commit 680f9f3)
bluetech
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #14220 as merged into main (680f9f3).
In
RaisesGroup._check_exceptions, the diagnostic section that builds failure messages for unmatched expected exceptions has a bug on this line:i_exphere is a leftover from the earlierfor i_exp, expected in enumerate(self.expected_exceptions):loop that computes the full results matrix. By the time we reach this diagnostic loop,i_expholds whatever value it had when that earlier loop finished -- it doesn't track the currenti_failediteration at all.This means the
results.get_result(i_exp, i_actual)call looks up the wrong expected exception's result, so the "It matches ... which was paired with ..." hints in the failure output can be completely wrong or missing.Fix: replace
i_expwithi_failed, which is the actual loop variable for the current expected exception being reported.