Deprecate the 'message' parameter of pytest.raises

[nicoddemus]

Fix #3974

[asottile]

ah doctests, I always forget those too ;)

[RonnyPfannschmidt]

that one should have been match, but its a good extra example that this is the right path forward

we mess up ourselves as is

[nicoddemus]

Hmmm better to remove the message example instead, will force-push soon.

[nicoddemus]

OK, ready. Also revamped the docs for pytest.raises. 👍

[codecov]

Codecov Report

Merging #4539 into features will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           features    #4539      +/-   ##
============================================
- Coverage     95.77%   95.76%   -0.02%     
============================================
  Files           111      111              
  Lines         24954    24961       +7     
  Branches       2462     2462              
============================================
+ Hits          23900    23904       +4     
  Misses          747      747              
- Partials        307      310       +3

Flag	Coverage Δ
#docs	29.33% <22.22%> (+0.05%)	⬆️
#doctesting	29.33% <22.22%> (+0.05%)	⬆️
#linting	29.33% <22.22%> (+0.05%)	⬆️
#linux	95.58% <100%> (-0.02%)	⬇️
#nobyte	92.42% <100%> (-0.01%)	⬇️
#numpy	93.22% <100%> (-0.02%)	⬇️
#pexpect	41.74% <22.22%> (-0.01%)	⬇️
#py27	93.81% <100%> (-0.02%)	⬇️
#py34	91.93% <100%> (+0.06%)	⬆️
#py35	91.96% <100%> (+0.06%)	⬆️
#py36	91.97% <100%> (+0.06%)	⬆️
#py37	93.95% <100%> (ø)	⬆️
#trial	93.22% <100%> (-0.02%)	⬇️
#windows	93.96% <100%> (-0.02%)	⬇️
#xdist	93.81% <100%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
testing/test_pytester.py	87.45% <100%> (ø)	⬆️
src/_pytest/deprecated.py	100% <100%> (ø)	⬆️
testing/deprecated_test.py	100% <100%> (ø)	⬆️
testing/python/raises.py	94.11% <100%> (+0.04%)	⬆️
src/_pytest/python_api.py	97.47% <100%> (+0.01%)	⬆️
src/_pytest/cacheprovider.py	95.75% <0%> (-1.42%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110fe24...5b83417. Read the comment docs.

[rth]

Thanks for making this happen!