Skip to content

Merge master into features - #5741

Closed
nicoddemus wants to merge 13 commits into
pytest-dev:featuresfrom
nicoddemus:mm
Closed

Merge master into features#5741
nicoddemus wants to merge 13 commits into
pytest-dev:featuresfrom
nicoddemus:mm

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Aug 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5741 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5741      +/-   ##
============================================
+ Coverage     96.25%   96.25%   +<.01%     
============================================
  Files           117      117              
  Lines         25902    25903       +1     
  Branches       2495     2495              
============================================
+ Hits          24932    24933       +1     
  Misses          666      666              
  Partials        304      304
Impacted Files Coverage Δ
src/_pytest/pytester.py 90.8% <ø> (ø) ⬆️
src/_pytest/outcomes.py 98.5% <ø> (ø) ⬆️
testing/test_pastebin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa75d81...998da2c. Read the comment docs.

Comment thread doc/en/skipping.rst Outdated
Comment thread doc/en/skipping.rst Outdated
Comment thread src/_pytest/outcomes.py Outdated
Comment thread src/_pytest/pytester.py Outdated
Co-Authored-By: Daniel Hahler <github@thequod.de>
@nicoddemus

Copy link
Copy Markdown
Member Author

Thanks!

Comment thread doc/en/reference.rst

.. autofunction:: _pytest.outcomes.skip(msg, [allow_module_level=False])

.. _`pytest.importorskip ref`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _`pytest.importorskip ref`:
.. _`pytest.importorskip`:

To fix:

Warning, treated as error:
/home/travis/build/pytest-dev/pytest/doc/en/skipping.rst:182:undefined label: pytest.importorskip (if the link has no caption the label must precede a section header)

That's why I had a "?" with the suggestion.. ;)

@nicoddemus

Copy link
Copy Markdown
Member Author

Hmmm nevermind this branch then, I will re-do the merge once we merge the pending PRs. 👍

@nicoddemus nicoddemus closed this Aug 15, 2019
@nicoddemus
nicoddemus deleted the mm branch August 15, 2019 13:05
nicoddemus pushed a commit to nicoddemus/pytest that referenced this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants