Skip to content

Add test to ensure _pytest is warning-clean on import - #5904

Merged
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:warnings_v2
Oct 7, 2019
Merged

Add test to ensure _pytest is warning-clean on import#5904
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:warnings_v2

Conversation

@asottile

@asottile asottile commented Oct 1, 2019

Copy link
Copy Markdown
Member

supersedes #4510

@asottile

asottile commented Oct 1, 2019

Copy link
Copy Markdown
Member Author

from a timing perspective, this test is less worse than I expected:

$ pytest testing/test_meta.py 
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-5.2.1.dev5+g9a4c0b991, py-1.8.0, pluggy-0.13.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/tmp/x/pytest/.hypothesis/examples')
rootdir: /tmp/x/pytest, inifile: tox.ini
plugins: hypothesis-4.38.1
collected 55 items                                                             

testing/test_meta.py ................................................... [ 92%]
....                                                                     [100%]

============================== 55 passed in 6.04s ==============================

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase so we can get a green CI before merging? Thanks!

@asottile
asottile merged commit 271dc7f into pytest-dev:master Oct 7, 2019
@asottile
asottile deleted the warnings_v2 branch October 7, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants