Allow for "pdb" module to be rewritten - #5920
Merged
Merged
Conversation
RonnyPfannschmidt
approved these changes
Oct 6, 2019
Contributor
Author
|
Note that it still tries to rewrite it ( pytest/src/_pytest/assertion/rewrite.py Lines 233 to 234 in c1361b4 |
nicoddemus
requested changes
Oct 6, 2019
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Missing changelog, otherwise LGTM. 👍
Member
|
Needs rebase once #5923 is merged |
Contributor
Author
Isn't that just noise? (quite internal isn't it?). |
blueyed
force-pushed
the
lazy-import-pdb
branch
from
October 6, 2019 21:03
cfb5290 to
07f20cc
Compare
Member
Fair enough. 👍 |
nicoddemus
approved these changes
Oct 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this with tests for pdb++.