Skip to content

[WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds - #5962

Closed
blueyed wants to merge 4 commits into
pytest-dev:masterfrom
blueyed:codecov-require_ci_to_pass
Closed

[WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds#5962
blueyed wants to merge 4 commits into
pytest-dev:masterfrom
blueyed:codecov-require_ci_to_pass

Conversation

@blueyed

@blueyed blueyed commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

Delays notification (and hopefully status) until CI has passed.

Delays notification (and hopefully status) until CI has passed.
@blueyed

blueyed commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Should be the default already..
But e.g. with #5961 it reports a status while Azure is not finished (but appears to be hanging in some way - no "Details" link there).

Via #5959 (where Travis was also not finished) - contacted @codecov support.
2019-10-15-031009_708x603_escrotum

@pytest-dev pytest-dev deleted a comment from codecov Bot Oct 15, 2019
@blueyed blueyed changed the title [WIP] ci: codecov: require_ci_to_pass: yes [W I P] ci: codecov: require_ci_to_pass: yes Oct 15, 2019
@blueyed blueyed changed the title [W I P] ci: codecov: require_ci_to_pass: yes [W I P] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds Oct 15, 2019
@nicoddemus nicoddemus changed the title [W I P] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds [WIP] ci: codecov: require_ci_to_pass: yes / notify.after_n_builds Oct 15, 2019
@nicoddemus

Copy link
Copy Markdown
Member

Did you use [W I P] here on purpose so CI would finish?

@blueyed

blueyed commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Did you use [W I P] here on purpose so CI would finish?

More to get a final status (it is a bit annoying that WIP makes it orange).

@blueyed blueyed closed this Oct 16, 2019
@blueyed
blueyed deleted the codecov-require_ci_to_pass branch October 16, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants